Repository navigation
Feat/BASE BUILDER CODE addition - #256
Merged
Merged
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e7dbafc. Configure here.
andriy-shymkiv
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adding Builder Code txCalldata suffix to fillOTCOrder transactions
part of FRNT-1287
Note
Medium Risk
Changes calldata sent to wallets/RPCs across all provider adapters; misconfiguration or incorrect suffix could break transactions, though scope is limited to optional build config and Base OTC fills.
Overview
Adds Base builder code attribution for direct OTC RFQ fills by appending a hex calldata suffix to outgoing transactions when built with
BASE_BUILDER_CODEand used on chain 8453.Build pipeline gains
dts.config.ts, which validates the env code, derives the suffix, and inlines it intoBASE_BUILDER_CODE_SUFFIXvia Rollup replace.constructFillOTCOrderpasses that suffix into bothfillOrderandpartialFillOrderWithTargetPermitpaths only on Base.Transaction plumbing is extended with optional
dataSuffixontransactCall(ethers v5/v6 signer wrappers, viemwriteContract, Web3 middleware) so integrators can honor the same behavior in custom callers. Version bumps to 11.0.1 with tests covering chain gating, provider encoding, and build-time validation.Reviewed by Cursor Bugbot for commit 6566d9d. Bugbot is set up for automated code reviews on this repo. Configure here.