Skip to content

Feat/BASE BUILDER CODE addition - #256

Merged
Velenir merged 8 commits into
masterfrom
feat/base-builder-codes-rfq
Oct 6, 2026
Merged

Velenir merged 8 commits into
masterfrom
feat/base-builder-codes-rfq

Conversation

@Velenir

@Velenir Velenir commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Adding Builder Code txCalldata suffix to fillOTCOrder transactions

part of FRNT-1287


Note

Medium Risk
Changes calldata sent to wallets/RPCs across all provider adapters; misconfiguration or incorrect suffix could break transactions, though scope is limited to optional build config and Base OTC fills.

Overview
Adds Base builder code attribution for direct OTC RFQ fills by appending a hex calldata suffix to outgoing transactions when built with BASE_BUILDER_CODE and used on chain 8453.

Build pipeline gains dts.config.ts, which validates the env code, derives the suffix, and inlines it into BASE_BUILDER_CODE_SUFFIX via Rollup replace. constructFillOTCOrder passes that suffix into both fillOrder and partialFillOrderWithTargetPermit paths only on Base.

Transaction plumbing is extended with optional dataSuffix on transactCall (ethers v5/v6 signer wrappers, viem writeContract, Web3 middleware) so integrators can honor the same behavior in custom callers. Version bumps to 11.0.1 with tests covering chain gating, provider encoding, and build-time validation.

Reviewed by Cursor Bugbot for commit 6566d9d. Bugbot is set up for automated code reviews on this repo. Configure here.

@linear-code

linear-code Bot commented Sep 29, 2026

Copy link
Copy Markdown

FRNT-1287

@github-actions

Copy link
Copy Markdown

size-limit report 📦

Path Size
dist/sdk.cjs.production.min.js 17.83 KB (+3.13% 🔺)
dist/sdk.esm.js 18.08 KB (+2.98% 🔺)

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e7dbafc. Configure here.

Comment thread src/helpers/providers/dataSuffix.ts Resolved
@Velenir
Velenir merged commit deb01b9 into master Oct 6, 2026
3 checks passed
@Velenir
Velenir deleted the feat/base-builder-codes-rfq branch October 6, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants