Repository navigation
Mining: similar to BIP 320, do not count the version bits miners roll for work as an unexpected version - #1091
Open
whiskyrelaxing wants to merge 1 commit into
Open
whiskyrelaxing wants to merge 1 commit into
whiskyrelaxing wants to merge 1 commit into
Conversation
…nexpected version.
Collaborator
|
Thanks, this looks right. The mask stays clear of the algo flags and the deployment bits, and it only affects the warning. Can you add a description saying which miner or setup is rolling these bits? |
Collaborator
|
ACK 9c38dd8. Tested on regtest, master against this PR, using a local test only change so -blockversion takes effect (regtest currently ignores it). Bit 13, all of bits 13 to 23, and rolled SHA256d stop triggering the warning. Bits 12 and 27 still trigger it. Master and PR nodes sync each other’s rolled blocks in both directions with the same tip and no rejects. Not tested with stake blocks or a real rolling miner. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sha256d asics roll these bits through stratum version rolling, the BIP 320 mask.