Conversation
xusheng6
marked this pull request as draft
September 22, 2026 16:38
xusheng6
force-pushed
the
test_corellium_socket_lifetime
branch
from
September 22, 2026 19:07
10a34e8 to
c6a3f24
Compare
xusheng6
changed the title
xusheng6
force-pushed
the
test_corellium_socket_lifetime
branch
from
September 22, 2026 19:19
c6a3f24 to
e871500
Compare
xusheng6
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1197 for R2 and applies the same socket ownership fix to GDB and Esreven, which used the same raw-pointer connection pattern. The adapter and RSP connector share socket ownership; shutdown is safe before connection and interrupts retries.
Validation
Unfixed
devcrashed under ASan when CorelliumQuit()ran beforeConnect(), atSocket::Kill()on an uninitialized pointer. The full Binary Ninja ASan build of this branch passed 20 Corellium pre-connect quits, plus 10 pre-connect and 10 connection-cancellation cycles for GDB and both Esreven connection paths. Live remote sessions were not exercised.