Repository navigation
Mark the re-exports of __init__.py for ruff - #23
Merged
Merged
Conversation
set_relative_file_base and FILE_BASE_VARIABLE are imported into __init__.py for run scripts, not used there, and ruff reported them as unused imports (F401), which fails the lint workflow on main since VUnit#12. Import them as X as X, which marks them as re-exports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
lintworkflow pass onmainagain.#12, merged after #22 added ruff, imports
set_relative_file_baseandFILE_BASE_VARIABLEinto__init__.pyso that run scripts can usevunit_python_bridge.set_relative_file_base(). They aren't used in__init__.pyitself, so ruff reports them as unused imports (F401), and thelintrun onmainfails. So does the lint check of every open PR, which all inherit it.This imports them as
X as X, which marks a name as a deliberate re-export for ruff. Nothing else changes.Tests
ruff checkand the license-header check pass.vunit_python_bridge.set_relative_file_baseandvunit_python_bridge.FILE_BASE_VARIABLEare still available.🤖 Generated with Claude Code