Repository navigation
fix use-after-free in OpenSSL Hash copy constructor - #703
Open
Bountybette wants to merge 1 commit into
Open
Bountybette wants to merge 1 commit into
Bountybette wants to merge 1 commit into
Conversation
Signed-off-by: waheeda bette <waheeda@research.digiscrypt.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the OpenSSL backend,
usbguard::Hashholds the digest context as anowning
EVP_MD_CTX*, but the copy constructor copied it by value:so a copy and its source share one heap context. The hashing path copies a
Hash (
Hash hash(_hash);inDevicePrivate::updateHash); when that copy isdestroyed while the source is still live,
EVP_MD_CTX_freereleases thecontext the source still points at.
ASan on the copy-then-use path:
The libgcrypt backend already deep-copies with
gcry_md_copyand libsodiumkeeps the state by value; only OpenSSL aliased. The copy constructor now
allocates a fresh context and copies into it with
EVP_MD_CTX_copy_ex,matching the default constructor. Added
test_Hash.cppasserting a copy isindependent of its source (fails under the asan job before this change).