Repository navigation
Conversation
aborjinik
had a problem deploying
to
netlify-preview
October 6, 2026 20:40 — with 
GitHub Actions
Failure
GitHub Actions
Failure
aborjinik
force-pushed
the
table-nested-slot-projection-support
branch
from
October 6, 2026 21:03
8fd398b to
ff7b2ee
Compare
aborjinik
had a problem deploying
to
netlify-preview
October 6, 2026 21:03 — with
GitHub Actions
Failure
GitHub Actions
Failure
aborjinik
had a problem deploying
to
netlify-preview
October 6, 2026 21:36 — with
GitHub Actions
Failure
GitHub Actions
Failure
Previously `UI5Element` always generated a property accessor for every declared slot, which prevented a component from exposing a custom getter for a slot. The generated accessor now steps aside when the component's prototype already defines a descriptor for the slot's property name, and `getSlottedNodes()` reads the raw slot content from `_state` so a component can call it from its own accessor. This enables resolving slotted children that are projected through a chain of `<slot>` elements across shadow DOM boundaries. `ui5-table` uses it for its `headerRow` and `rows` slots, and `TableRowBase._table` now walks up via `assignedSlot` so forwarded rows still find their owning table.
aborjinik
force-pushed
the
table-nested-slot-projection-support
branch
from
October 6, 2026 22:00
ff7b2ee to
22e2dec
Compare
|
🚀 Deployed on https://pr-14128--ui5-webcomponents-preview.netlify.app |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
UI5Elementalways generated a property accessor for every declared slot, which prevented a component from exposing a custom getter for a slot. The generated accessor now steps aside when the component's prototype already defines a descriptor for the slot's property name, andgetSlottedNodes()reads the raw slot content from_stateso a component can call it from its own accessor.This enables resolving slotted children that are projected through a chain of
<slot>elements across shadow DOM boundaries.ui5-tableuses it for itsrowsandheaderRowslots, andTableRowBase._tablenow walks up viaassignedSlotso forwarded rows still find their owning table.