Repository navigation
Conversation
…down with min/maxDate
|
🚀 Deployed on https://pr-14122--ui5-webcomponents-preview.netlify.app |
GDamyanov
self-requested a review
October 6, 2026 08:17
GDamyanov
requested changes
Oct 6, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when
maxDatewas set onui5-date-pickerorui5-calendar, selecting a valid day from the next month while viewing the previous month (grey trailing "other month" cells) often only switched the month view. The popover stayed open and the value did not update until a second click. WithoutmaxDate, the same gesture usually worked.With this change we complete mouse selection in
ui5-day-picker. Mousedown already navigates to the clicked month beforeclickruns; withmaxDate, many days in that month are disabled, so mouseup often missed the day cell and_selectDatereturned early.Before
After
Fixes: #14046