Repository navigation
fix(UI5Element): make focus() synchronous when the shadow DOM is ready - #14118
Open
TeodorTaushanov wants to merge 10 commits into
Open
TeodorTaushanov wants to merge 10 commits into
TeodorTaushanov wants to merge 10 commits into
Conversation
|
🚀 Deployed on https://pr-14118--ui5-webcomponents-preview.netlify.app |
TeodorTaushanov
changed the title
TeodorTaushanov
had a problem deploying
to
netlify-preview
October 5, 2026 12:34 — with 
GitHub Actions
Failure
GitHub Actions
Failure
TeodorTaushanov
changed the title
TeodorTaushanov
requested review from
a team,
ilhan007,
nnaydenow,
pskelin and
vladitasev
October 6, 2026 06:51
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
focus()focuses synchronously when the element is already renderedand not queued for a (re-)render. If a render is still pending, it waits
for the DOM ref as before, since the focus DOM ref may be stale or missing.
Components that bypass it with their own focus-forwarding logic — like ToolbarItemBase.focusForToolbarNavigation(), which calls getFocusDomRef()?.focus() directly don't get that guarantee. In those cases the component must await this._waitForDomRef() explicitly before running its own logic, to ensure the DOM ref is ready.
fixes #14117