Repository navigation
fix(ui5-tokenizer): fix render loop - #14115
Open
aleksandar-terziev wants to merge 8 commits into
Open
aleksandar-terziev wants to merge 8 commits into
aleksandar-terziev wants to merge 8 commits into
Conversation
aleksandar-terziev
requested review from
Vonahz,
ndeshev,
nikoletavnv and
nnaydenow
October 1, 2026 14:20
aleksandar-terziev
force-pushed
the
tokenizer-nmore-render-loop
branch
4 times, most recently
from
October 2, 2026 14:57
4395ab3 to
890fdc4
Compare
aleksandar-terziev
force-pushed
the
tokenizer-nmore-render-loop
branch
from
October 6, 2026 10:56
c7c3cd7 to
f4aa68e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix render loop with Korean locale tokens
Tokenizer.overflownTokensmeasuredparentRectinside the token loop after eachtoken.overflowswrite.DOM mutations from hiding/showing tokens caused layout recalculations mid-loop
With CJK locales (Korean, Japanese, Chinese), the two n-more label variants ("N개 항목 더 보기" vs "N개 항목") have a large enough width to flip a token between overflow/not-overflow on every render cycle until RenderQueue throws:
Web component processed too many times this task, max allowed is: 10Changes:
parentRectmeasured once before the loop, not per token_lastNMoreWidth— saves n-more width to the historical maximum so a narrower label variant on the next render does not release a token backTest:
MultiComboBox.spec.js— loads the page with?sap-ui-language=koand asserts the n-more popover opens without crash.