Repository navigation
feat(ui5-dialog): open as a native modal <dialog> via showModal() - #14077
LidiyaGeorgieva wants to merge 26 commits into
Conversation
…ed above it A native modal <dialog> owns the topmost CloseWatcher, so its cancel event fires on Escape even when a non-native popup (Select/ComboBox dropdown or Popover) is open above it. The OpenedPopupsRegistry now records when it has consumed an Escape by closing such a popup, and Dialog._onCancel skips closing the dialog in that case, matching the previous single-close behavior.
👋 Heads-up: dev close is in effectThanks for the contribution! This repository is currently in dev close ahead of release This PR appears to introduce public-API changes (detected by diffing the Custom Elements Manifest against the latest published version on npm):
Could you please hold off on merging into If this change must ship in the current release, please request a review from one or two members of @UI5/ui5-team-webc so the team can sign off explicitly.
Posted automatically by the Dev Close Notice workflow. |
|
🚀 Deployed on https://pr-14077--ui5-webcomponents-preview.netlify.app |
…s into DilaogRefactorRendering
Migrate ui5-dialog to render its popup root as a native and open
it with showModal() instead of the Popover API. The browser now owns the
top-layer placement, focus trap, background inert, ::backdrop and Escape
handling, fixing several accessibility issues where the dialog was
obscured by the block layer or assistive tech could escape the modal and
reach the underlying page (#7938, #6902, #13906).
Fixes #7938
Fixes #6902
Fixes #13906