Repository navigation
Retain guarded CDP authority across CLI and holder restart - #18
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cad7508f8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…vation (cherry picked from commit e381800)
(cherry picked from commit 605d257)
…rrection (cherry picked from commit 186009e)
…rapper cleanup (cherry picked from commit d4a312a)
(cherry picked from commit ae7f396)
…w artifact (cherry picked from commit eaba616)
…eplay receipts (cherry picked from commit c501100)
(cherry picked from commit 36aba24)
…sor observer (cherry picked from commit bb6851a)
…ined histories (cherry picked from commit 7a874eb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An interrupted browser activation can outlive the CLI that requested it. This adds an explicit
footwork browser cdpholder that preserves the exact observed document binding and commits guarded intent before activation. Stable tokens retrieve the original operation after CLI or holder restart; uncertainty blocks another mutation in the shared authority database.Browser evidence uses a separate versioned producer. Native validators and legacy CUA behavior remain unchanged. Startup now retains the actual Chrome handle through interruption and reports cleanup uncertainty separately. Doctor, tools, schema and the installed
browser cdp guideexpose the new route and its requirements.Typing stays disabled. An activation acknowledgement remains completion-unverified; qualified completion readers, pipe custody, the light dependency-metadata split and a measured small-VM resource profile remain open.
Validation: 2,685 local regression tests passed (95 skipped, 60 browser/live deselected). The exact wheel passed all 201 installed checks on both macOS and the Linux VM without CUA/browser-use. Independent ingress controls retained 0/0/1 effects at prepared/start/retained-result interruption boundaries and one effect after client-loss replay. Review findings were remediated and rechecked. Test-only subreaping is reported separately from product cleanup.
Implementation, grounding and review report · VM receipts and retained failures