Conversation
1 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where JavaScript comments in the payload formatter code editor are unreadable in dark mode due to dark grey text on a black background.
Changes
.ace-ttn-dark .ace_commentcolor fromvar(--c-text-neutral-extralight)tovar(--c-text-neutral-semilight)inpkg/webui/components/code-editor/ttn-theme.js.ttn-darktheme definition (--c-bg-neutral-extalight→--c-bg-neutral-extralight,--c-border-brand-norma→--c-border-brand-normal, and--c-text-neutral-max→--c-text-neutral-heavy).[Unreleased]inCHANGELOG.md.Testing
Steps
// Single-line commentor/* Multi-line comment */).Results
--c-text-neutral-extralight, resolving to$c.neutral-900(#1C293F), appearing dark grey on a black (#000000) background with a contrast ratio of ~1.3:1 (unreadable).--c-text-neutral-semilight, resolving to$c.neutral-400(#B2BAC8), rendering in light grey with a contrast ratio of ~10.9:1 (WCAG AAA compliant and clearly legible).Regressions
ttn-light) styling is untouched (#8E908C).Notes for Reviewers
In
tokens.styl,theme-dark.color['text-neutral-extralight']is mapped to$c.neutral-900(#1C293F), representing minimum contrast on dark surfaces. Usingvar(--c-text-neutral-semilight)($c.neutral-400/#B2BAC8) provides a distinct light grey appearance that is clearly readable while remaining visually secondary to primary code text (var(--c-text-neutral-heavy)/#EBEEF3).Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.