[rdeago]

Checklist of related issues / discussions

• Closes A project reference is packed as a dependency at version 1.0.0 #417
• Part of #
• Related discussion(s): #

Proposed changes

When a project is packed, the nuspec lists each project reference at version 1.0.0, whatever version Buildvana SDK computes for the referenced project.

NuGet gets the version of a project reference by running _GetProjectVersion on the referenced project. That target runs only $(GetPackageVersionDependsOn), then returns $(PackageVersion), or 1.0.0 when the property is empty. GetBuildVersion hooks the build, pack, and restore targets through BeforeTargets, and none of them run in that call. So PackageVersion stayed empty. The regression dates from a17ee83, which replaced Nerdbank.GitVersioning with the Versioning module.

The fix adds GetBuildVersion to GetPackageVersionDependsOn, in src/Buildvana.Sdk/Modules/Versioning/Module.Core.targets. The BeforeTargets list stays as it is, because each of its entries covers a path that GetPackageVersionDependsOn does not reach.

VersioningModuleTests.GetProjectVersion_ReturnsTheComputedVersion runs _GetProjectVersion on a project in a temporary Git repository. The project imports the real targets of the module and of NuGet pack. The test checks the version that _GetProjectVersion returns. Without the fix, the test gets 1.0.0.

The GetBuildVersion section of docs/sdk-modules/versioning.md says that the target also runs when a referencing project is packed.

Additional changes

None.

Types of changes

This pull request introduces the following types of changes:

• Bug fix
• New feature
• Test addition / update (no changes to non-test code)
• Refactor (no changes in public API syntax or semantics)
• Performance improvement (no changes in public API syntax or semantics)
• Documentation update (not including changelog)
• Dependency addition / update
• Changes to toolchain configuration
• Changes to CI (workflows, bot / app configurations)
• Changes to repository files (.gitattributes, .gitignore)
• Other

Breaking changes

This pull request introduces breaking changes:

• Yes
• No

Checklist

• For all types of changes:
  • I have read the Code of Conduct and agree to be bound by it
  • I have read the Contributor Guide and agree to follow it
• For code changes only:
  • The project builds on my machine, via the provided build script, with zero warnings
  • I have added tests that prove my feature works / my fix is effective
  • I have added / modified XML documentation according to changes in code
  • I have checked that all the links I added or modified in XML documentation point to their intended destination
• For documentation changes only:
  • I have checked and proofread documentation locally
  • I have checked that all the links I added or modified point to their intended destination

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.50%. Comparing base (f08fc6b) to head (28c8470).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #418   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files         330      330           
  Lines        9769     9769           
  Branches     1824     1824           
=======================================
  Hits         8548     8548           
  Misses        919      919           
  Partials      302      302           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rdeago]

Review by Claude. Self-review.

👍 Approved.

---

No blocking findings.