Repository navigation
Fix Ge qCrit interpolation - #1486
Merged
ilyamandel merged 2 commits intoSep 24, 2026
Merged
Conversation
ilyamandel
requested changes
Sep 22, 2026
ilyamandel
left a comment
ilyamandel
left a comment
Collaborator
There was a problem hiding this comment.
Hi @Dylan-Hebrail ,
This looks great, thank you so much for doing this (and sorry for the very late response -- took me a long time to catch up after travelling).
Just one request: could you please also update changelog.h to assign this a new version number and a brief comment?
Collaborator
|
Looks good! Could you also make the identical fixes to the relevant parts of the HeMS file? |
reinhold-willcox
approved these changes
Sep 23, 2026
Contributor
Author
|
Hi @ilyamandel, @reinhold-willcox, I updated the PR with your requests! In HeMS, the relevant function only interpolates for R and M so I changed only these two interpolation factors. |
jeffriley
approved these changes
Sep 24, 2026
jeffriley
left a comment
jeffriley
left a comment
Collaborator
There was a problem hiding this comment.
All good from me. Thanks Dylan!
ilyamandel
approved these changes
Sep 24, 2026
ilyamandel
left a comment
ilyamandel
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @Dylan-Hebrail !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the interpolation in MainSequence::InterpolateGeEtAlQCrit(), addressing both problems presented in #1484.
The radius and mass interpolation factors used (upper - x) / (upper - lower), which reversed the interpolation. These are changed to (x - lower) / (upper - lower).
The beta interpolation selected the beta interval [0, 0.5] or [0.5, 1], but used the global beta value as the interpolation factor. This change rescales beta locally within the selected interval before interpolating.
The modified code builds successfully using Clang on macOS. I tested it by producing the same plot as shown in Issue #1484, it now looks like this:
The change removed the sawtooth aspect matching the grid points.
Addresses #1484.