fix(create): resolve current npm versions - #517
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthrough
Changesnpm version resolution
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Generated projects resolve current npm versions while retaining the existing fallback when lookups fail. No actionable merge-blocking risk is identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
packages/create/tests/npm-resolver.test.tsParsing error: "parserOptions.project" has been provided for Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The npm
latestendpoint rejects the install metadata response format, so generated projects currently fall back to an unpinnedlatestspecifier. Request JSON from that endpoint and resolve versions for each generated project, allowing long-running builders to pick up new releases.Adds regression coverage for the HTTP 406 response and a new release becoming available between generations. Includes a patch changeset for
@tanstack/create; Changesets also updates the CLI and its published aliases.Validation: creation-engine lint, TypeScript build, all 267 tests, and formatting passed. Fresh React and Solid projects from the published CLI and live builder resolve the current Start and core packages.
Summary by CodeRabbit