[ryanbarlow97]

A realm treasury can cross into bankruptcy without dirtying province economics. Quiet exports could then publish its current negative bank with cached trade/production from before bankruptcy. A direct or single-guild flood between two treasury transitions could also leave the guarded cache marked fresh for outputs from the wrong state.

Refresh dirty economics before exporting live provinces, guilds and Chronicle. Guarded recalculation checks realm-bank bankruptcy alongside the model version; every completed full recalculation records that state, and partial/failed floods invalidate it. Same-state balance changes retain the cache. Chronicle uses the refreshed trade for its existing prestige update. Bank balances and settlement code are unchanged.

Validation: the original bankruptcy/export regressions fail before the fix. Three added regressions fail on the first revision and pass on the final revision: recovery after direct full and single-guild floods, and no duplicate guarded flood after a completed full recalculation. All 37 affected-suite tests pass. Final TFMC_MVN_REMOTE=0 tfmc-mvn -o -B clean verify passed all 8,510 tests with no failures, errors or skips and zero missed-line coverage. Runtime JAR validation and GitHub CI pass on head 0335990.

Independent Opus 5.5 and Muse reviews both accepted final head 0335990 with no blockers. Their direct/partial recalculation finding was reproduced and fixed before merge. No live plugin or server has been changed by this PR.

Documentation: TF-Minecraft/Docs#313

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}