Repository navigation
feat: give every CustomCrops crop the same death chance - #85
Merged
Merged
Conversation
Each crop now has a 12% chance to die per grow at fertility 78, the median province fertility under the 671 crops planted on Main. The per-update rate is solved from each crop's stage count and Cooking affection, so stage counts, drops and affection stay unchanged. Crops that regrow from stage 2 after harvest only roll death from stage 2 up (point-more-than 1), so each regrowth also carries 12%. Strawberry regrows from stage 0 and keeps the normal rule. Main ran hand-tuned rates (2.5-14.4% per update) that were never committed; this replaces both those and the flat 5% kept here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
github-actions
Bot
added
the
size:M
Contributor
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TFMC_Map/customcrops/*.mccon 2026-10-23).randomvalue is solved per crop from its stage count and its Cookingaffection:p = g(1-s) / (s + g(1-s)), withg = 0.78^affectionands = 0.88^(1/k), wherekis the number of stages that roll death. Stages, drops, growth conditions and affection are unchanged.point-more-than: 1; checked in CustomCrops 3.6.56 as a strict>). Both the first grow and every regrowth then carry 12%. Strawberry regrows from stage 0 and keeps the normal rule.CustomCrops checks death before growth on every crop update while the crop is unripe, so slower growth (low fertility or dry soil) means more death rolls. Affection is kept on purpose. Crops end up equal on good land and only drift apart on poor land:
Figures assume natural growth, soil kept wet and the fertility gate on. Bone meal can skip a stage, which also skips that stage's death roll. Trade-off: a regrowing crop at stage 0–1 no longer dies, so on fertility 0 or dry soil it waits instead of withering.
Documentation impact
Contract
death-conditionsonly. Drops, stages, grow conditions and Cookingcrops.ymlaffection are unchanged.mvn test, or why not): not run. Config-only change outsidesrc/. Every file was diffed against Main's live copy; the only differences are the death-rule lines.ProvinceSystem/wiki/cookingor related pages): no change. It does not mention crop death.Notes
plugins/CustomCrops/contents/crops/files on each server, not the Cooking jar. Rollout: Dev first, then Main as an agreed live change.🤖 Generated with Claude Code