Repository navigation
gateway: the /gui/ board launches engines that have no web UI - #137
Merged
Merged
Conversation
The board drew a Launch button for every engine with a start command, but the wake endpoint also required a gui URL, so Launch on Strata or a llama-server answered 404 and the button stayed on "Launching...". The endpoint now takes any engine with a start command; the per-engine wake page still needs a gui URL, since it exists to send the browser there. On the page, an engine with no web UI shows Running once it answers instead of an Open button that navigated to "undefined", and a refused start shows its reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
/gui/board shows a Launch button for every engine with astartcommand. The wake endpoint behind it also required aguiURL, so on an engine without one (Strata, a bare llama-server) Launch answered 404 and the button stayed on "Launching..." for good. Once such an engine came up some other way, its row showed Open, which navigated toundefined.Change
POST /gui/{name}/wakeaccepts any engine with astartcommand.GET /gui/{name}(the wake page) still needs aguiURL, because its job is to send the browser to that UI.docs/gateway.mdand CHANGELOG.Scope note
The keyless plane can now start every engine with a
startcommand, not only those with aguitoo. The guards are unchanged: loopback or--allow-hostnames only, and a start must be a same-origin POST. The gateway's keyed API could already start these engines.Proof
TestGUIPlaneLaunchAPIOnly: launching an API-only engine from the board. It fails on main (wake = 404) and passes here. It also checks that the engine ends up holding the lease, and that its wake page stays a 404."Open", enabled; a refused start stays on"Launching..."."Running", disabled; a refused start shows"comfyui did not start"with the server's reason.go test ./..., Windows build and vet, golangci-lint (0 issues).