Skip to content

fix(bootstrap-admin-ui): translate login error with its parameters and the security domain #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rafikooo wants to merge 1 commit into from
Closed

fix(bootstrap-admin-ui): translate login error with its parameters and the security domain #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BootstrapAdminUi/templates/security/login/page/content/form/error.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

{% if last_error is not null %}
<div class="alert alert-danger" {{ sylius_test_html_attribute('invalid-credentials-message') }}>
{{ last_error.messageKey|trans }}
{{ last_error.messageKey|trans(last_error.messageData, 'security') }}
</div>
{% endif %}
35 changes: 35 additions & 0 deletions tests/Translations/FrenchTranslatedLoginTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<?php

declare(strict_types=1);

namespace MainTests\Sylius\Translations;

use Symfony\Bundle\FrameworkBundle\KernelBrowser;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Zenstruck\Foundry\Attribute\ResetDatabase;

#[ResetDatabase]
final class FrenchTranslatedLoginTest extends WebTestCase
{
use MarkTestSkippedTrait;

private KernelBrowser $client;

protected function setUp(): void
{
$this->client = static::createClient();
}

public function testInvalidCredentialsMessageIsTranslated(): void
{
$this->markTestSkippedIfNecessary('fr');

$this->client->request('POST', '/admin/login_check', [
'_username' => 'nonexistent@example.com',
'_password' => 'wrong-password',
]);
$this->client->followRedirect();

self::assertSelectorTextContains('[data-test-invalid-credentials-message]', 'Identifiants invalides.');
}
}
Loading