Repository navigation
Update dependencies and fix product picker on iPhone - #119
Merged
Merged
Conversation
Hold mermaid at 11: astro-mermaid 2.1.0 only supports mermaid 10 and 11.
Safari never focuses a tapped link, so the summary lost focus with no relatedTarget and the focusout handler closed the list before the click landed. Close on focusout only when focus moves to a known element outside the picker; the click handler already covers outside taps.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 6dc7f24 | Oct 14 2026, 07:46 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies
Mermaid stays on 11.17.2. Version 12 is out, but astro-mermaid 2.1.0 (the latest) only supports mermaid 10 and 11.
Product picker on iPhone
On iOS Safari, tapping a product in the documentation picker did nothing, so you could not switch from Chatbot to SE.Live. Chrome worked.
Safari focuses the
<summary>on tap but never focuses a tapped link. The summary then lost focus withrelatedTargetset to null, and thefocusouthandler took that as focus leaving the picker. It closed the list, and the tap landed on the sidebar underneath. The handler now closes the list only when focus moves to an element outside the picker. The existing click handler still closes it on taps outside.Testing
pnpm buildpasses and all internal links are valid. Its three warnings also show up onmaster./selive, where before it stayed on/chatbot. Tapping outside the picker and pressing Escape still close the list.