Repository navigation
test: wait for the watchdog to stop between tests - #75
Merged
Merged
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flaked on #73's macos job.
test_exits_once_the_worker_overruns_its_deadlineleaves its watchdog firing every 10ms and teardown only sets the stop event, so on a slow runner the thread can wake up in the next test and call that test's_exit_wedgedmock (the captured setup log said "1.1s past its deadline", which is the previous test's deadline). Fixture now joins the watchdog before the mocks come off.Reproduced locally by putting a 50ms sleep before the exit call, fails without the join and passes with it.
Also points every test at a temp socket and pid file. A stray real
_exit_wedgedduring a local test run deleted my live daemon's socket, so the daemon kept running but nothing could reach it and callouts just stopped.