Skip to content

docs: point agents at the shared MCP session and end-user retry helpers - #275

Open
glebedel wants to merge 3 commits into
mainfrom
s2d2/audit-claude-md-mcp-plumbing
Open

glebedel wants to merge 3 commits into
mainfrom
s2d2/audit-claude-md-mcp-plumbing

Conversation

@glebedel

@glebedel glebedel commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

What

Two lines in CLAUDE.md (and AGENTS.md, its symlink) catch up with #261 and #274, both now on main:

  • "Modifying Tool Behaviour" names _run_mcp_session() (transport, deadline and failure mapping for every list and call) and retry_for_end_user() (the one retry after an end-user refusal), the two helpers refactor: share the MCP session and end-user retry plumbing #261 introduced.
  • The dependency-tier note says the MCP transport runs on httpx2 under mcp 2 and why it is not declared: mcp 2 requires it itself. A reviewer flagged the undeclared import as a breach of this note during feat(deps): support mcp 2 alongside mcp 1 #274; this records the decision so the next agent does not "fix" it.

Why

A second review pass over #261, now shipped inside #274's squash, found no code issue. The only stale material was this guidance file.

How verified

Each claim checked against stackone_ai/tools.py on main: both helpers exist and every listing and call goes through them. GET /accounts uses the httpx client, and the MCP transport uses _mcp_http. The examples and README needed no change: none uses the changed internals, and MIGRATION.md's end-user section still matches the code.

Gates (head dd51301)

Gate Result
Forge not run: docs only, no code
Security scan / Codex security / /security-review not run: docs only
/code-review not run: docs only; claims checked by hand above
Demo no runtime change, no demo

Post-merge validation

None needed: no release (docs does not trigger release-please).

Requested by guillaume@stackone.com in Slack (repo audit thread).

🤖 Generated with Claude Code


Summary by cubic

Updates the agent-facing guidance in CLAUDE.md to match the shared MCP session and end-user retry helpers now on main.

  • "Modifying Tool Behaviour" now names _run_mcp_session() for MCP session setup and retry_for_end_user() for end-user retries as the single places for each concern.
  • The dependency note records that the MCP transport runs on httpx2 under mcp 2, which requires it itself, so it is not declared as a core dependency.

Docs only, no code change and no release.

Written for commit 6f71924. Summary will update on new commits.

View guided diff Turn on auto-fix

The MCP session plumbing and the end-user retry now live in one place each
(_run_mcp_session and retry_for_end_user), so the "Modifying Tool Behaviour"
list names them. The dependency note says why httpx2, which the transport
uses on mcp 2, is not a declared core dependency: mcp 2 requires it itself.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
glebedel and others added 2 commits November 14, 2026 04:02
The failing test (test_requests_refused_together_share_one_accounts_listing)
is unrelated to this docs-only change and passed on the prior head.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
@glebedel

Copy link
Copy Markdown
Contributor Author

@willleeney a nudge on this one when you have a moment. This PR: point agents at the shared MCP session and end-user retry helpers.

Why it should be a quick review: +5 -1 across 1 file, CI green on the current head, forge and /code-review already run, no open review threads. It only needs an approving review to merge.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants