Repository navigation
Conversation
The MCP session plumbing and the end-user retry now live in one place each (_run_mcp_session and retry_for_end_user), so the "Modifying Tool Behaviour" list names them. The dependency note says why httpx2, which the transport uses on mcp 2, is not a declared core dependency: mcp 2 requires it itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
The failing test (test_requests_refused_together_share_one_accounts_listing) is unrelated to this docs-only change and passed on the prior head. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
Contributor
Author
|
@willleeney a nudge on this one when you have a moment. This PR: point agents at the shared MCP session and end-user retry helpers. Why it should be a quick review: +5 -1 across 1 file, CI green on the current head, forge and /code-review already run, no open review threads. It only needs an approving review to merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two lines in
CLAUDE.md(andAGENTS.md, its symlink) catch up with #261 and #274, both now onmain:_run_mcp_session()(transport, deadline and failure mapping for every list and call) andretry_for_end_user()(the one retry after an end-user refusal), the two helpers refactor: share the MCP session and end-user retry plumbing #261 introduced.httpx2under mcp 2 and why it is not declared: mcp 2 requires it itself. A reviewer flagged the undeclared import as a breach of this note during feat(deps): support mcp 2 alongside mcp 1 #274; this records the decision so the next agent does not "fix" it.Why
A second review pass over #261, now shipped inside #274's squash, found no code issue. The only stale material was this guidance file.
How verified
Each claim checked against
stackone_ai/tools.pyonmain: both helpers exist and every listing and call goes through them.GET /accountsuses the httpx client, and the MCP transport uses_mcp_http. The examples and README needed no change: none uses the changed internals, andMIGRATION.md's end-user section still matches the code.Gates (head dd51301)
Post-merge validation
None needed: no release (
docsdoes not trigger release-please).Requested by guillaume@stackone.com in Slack (repo audit thread).
🤖 Generated with Claude Code
Summary by cubic
Updates the agent-facing guidance in
CLAUDE.mdto match the shared MCP session and end-user retry helpers now onmain._run_mcp_session()for MCP session setup andretry_for_end_user()for end-user retries as the single places for each concern.httpx2under mcp 2, which requires it itself, so it is not declared as a core dependency.Docs only, no code change and no release.
Written for commit 6f71924. Summary will update on new commits.