Skip to content

fix(deps): require the patched mcp and python-dotenv releases - #265

Merged
glebedel merged 8 commits into
mainfrom
s2d2/audit-raise-dependency-floors
Nov 11, 2026
Merged

glebedel merged 8 commits into
mainfrom
s2d2/audit-raise-dependency-floors

Conversation

@glebedel

@glebedel glebedel commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Raises two dependency floors so people who install stackone-ai get the security fixes, not only this repo. uv.lock is not part of the published package, so #264's lockfile bumps protect CI and contributors but not users: with mcp>=1.24.3, an environment that already has mcp 1.25 keeps it, along with its open advisories.

Builds on #264. Merge #264 first; this PR's own change is the last commit, 2 lines in pyproject.toml and the 2 matching requires-dist lines in uv.lock.

Dependency Floor before Floor after Why
mcp (core) >=1.24.3,<2.0.0 >=1.30.0,<2.0.0 first release that fixes every open mcp advisory on 1.x
python-dotenv (examples extra) >=1.0.1 >=1.2.2 first release that fixes GHSA-mf9w-mj56-hr94

How it was verified

The built wheel now declares Requires-Dist: mcp<2.0.0,>=1.30.0 and Requires-Dist: python-dotenv>=1.2.2; extra == 'examples'. Resolving the wheel next to an environment pinned to mcp==1.25.0:

main wheel:     mcp==1.25.0  (accepted)
this branch:    error: No solution found when resolving dependencies
                stackone-ai==3.0.0 depends on mcp>=1.30.0,<2.0.0 ... your requirements are unsatisfiable.
Check Result
uv sync --locked --all-extras (Python 3.13), uv lock --check ok
ruff check, ruff format --check, ty check stackone_ai examples clean
uv run pytest 871 passed

The cost for consumers: anyone pinned to an older mcp gets a resolver conflict and has to upgrade, which is the point.

Not in this PR, left for a separate decision because they constrain what users' own apps can install: the adapter floors langchain-core>=0.3.36 and pydantic-ai-slim>=1.83.0 admit releases with published advisories, and pydantic>=2.10.6 admits releases affected by pydantic's four medium advisories (this repo's lock is on the fixed 2.14.2 since #251). The mcp<2.0.0 cap stays: the 2.x move is #208.

Gates

Gate Result
/forge:forge n/a, two version specifiers and their lock metadata, no code (meter: 0 findings)
Security scan dependency reviewer on 1fe5e5f: both new floors exclude every vulnerable release in OSV; flagged the adapter floors above (left for a decision). Aikido: no open issue on these lines
Codex security 1fe5e5f: no finding in the change; flagged pydantic's own advisories, now locked to 2.14.2 (since #251)
/security-review ran on 1fe5e5f: no secrets, no code path changed; server-side items do not apply
/code-review medium on 1fe5e5f: floors confirmed against the advisory database, no CLAUDE.md breach. Declined: raising pydantic>=2.11.0 to mirror mcp's own requirement (the resolver already enforces it through mcp, and a copy is a second place to keep in sync); lifting the <2.0.0 cap (out of scope, #208)
CI green on 3eef8ce: 10 pass (3.11, 3.12, 3.13, conformance, gitleaks, Aikido), 3 skipped
Unresolved review threads 0

Requested by guillaume@stackone.com in Slack (repo audit thread).

🤖 Generated with Claude Code

s2d2-s1 and others added 6 commits November 11, 2026 01:10
Moves the locked versions of vulnerable Python and mock-server packages to
patched releases inside the ranges pyproject.toml already allows. The mock
server's exact @modelcontextprotocol/sdk pin moves from 1.24.3 to 1.32.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
Relocks from main with exact versions (the highest first-patched version of
each alerted package), so nothing moves further than the advisories require
and every new release is at least 14 days old, in line with the 7-day
minimumReleaseAge the mock server already enforces. Moves body-parser in the
mock server to 2.4.0 for GHSA-27r3-jxmh-p828.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
…s through

langgraph-sdk 0.4.6 is the first patched version and resolves with langgraph
1.2.14, so the lock goes no further. The mock server's MCP SDK ignore now
blocks majors only, as its comment says: 1.32.1 still serves the raw
inputSchema, and ignoring every version also hid future security updates.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
uv.lock is not part of the published package, so the lockfile bumps only
protect this repo. With the floors at mcp>=1.24.3 and python-dotenv>=1.0.1,
an environment that already has mcp 1.25 keeps it when stackone-ai is
installed. The floors now start at the first release that fixes every open
advisory (mcp 1.30.0, python-dotenv 1.2.2), so the resolver upgrades instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
pydantic published four medium advisories (GHSA-955g-x97g-8mcp,
GHSA-gj4f-r7mf-jjxh, GHSA-3r8g-cqwr-jr29, GHSA-qpmf-fgh3-ff25) that affect the
locked 2.12.5 and are fixed in 2.14.2. They are not in the global advisory
database yet, so Dependabot has not raised them. cohere moves to 7.2.0, the
oldest release that accepts the new pydantic-core; typing-inspection stays on
0.4.4 to respect the 7-day release age.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
@glebedel glebedel self-assigned this Nov 11, 2026
s2d2-s1 and others added 2 commits November 11, 2026 11:40
Conflicts in package.json, pnpm-lock.yaml and uv.lock after main took the
hono 4.13.16 bump and the grouped Python updates. package.json keeps this
branch's MCP SDK 1.32.1 and main's hono 4.13.16. uv.lock starts from main
and re-applies this branch's security bumps, so no package is lower than on
either side.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
…lockfiles branch

That branch already carries main and the lockfile conflict resolution, so
this merge applies cleanly. The raised mcp and python-dotenv floors sit on
top of it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
@glebedel
glebedel merged commit 43ebf5e into main Nov 11, 2026
13 checks passed
@glebedel
glebedel deleted the s2d2/audit-raise-dependency-floors branch November 11, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants