Repository navigation
chore: clear out stale config and fix small doc and test gaps - #262
Merged
Merged
Conversation
- release-please: drop the bump-*-pre-major flags, which only apply below 1.0 (the package is at 3.0.0). - gitleaks: drop the venv/ allowlist entry; .venv/ is the only virtualenv the repo uses and stays allowlisted. - pyproject: drop the E501 ignore for examples (no line is over 110), the py.typed coverage omit (coverage only measures .py files) and an exclude_lines that restated the default; add [project.urls] so the PyPI page links the repo, changelog and issues. - dev extra: add pydantic-ai-slim, as langchain-core already is, and turn the pydantic_ai importorskip calls into plain imports, so those tests fail on a dev-only install instead of silently skipping. - fetch_tools(mode=...) is typed ToolMode | None and documented. - MIGRATION.md: the 3.0 hand-built tool snippet gets its imports. - validate.sh: the header named a different ADK checkout than the default it uses. - dependabot.yaml: the npm comment said major-only, but the MCP SDK is ignored entirely. - Tools._warn_duplicate_names: the docstring said "once", but it also warns from each adapter, which tests pin deliberately. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
- fetch_tools(mode=...): the default is now a one-member enum, so the annotation states the sentinel instead of hiding it behind a ty ignore, and ty narrows it away after the default is resolved. - pyproject: examples pass ruff with no per-file ignores, so the remaining F841 and E402 entries go with E501. - Tools._warn_duplicate_names: the docstring repeated what _first_per_name already says about adapters; it now states only that it warns on every call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
…type The typed sentinel put a private enum into the public signature (`ToolMode | None | Literal[_Unset.UNSET]`), which IDEs and help() show to every caller. `ToolMode | None` with one inline ty ignore on the default states the public contract more plainly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
The duplicate-names warning moves to construction only in the warn-once change, so this PR leaves the original docstring as it is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com> # Conflicts: # .github/dependabot.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Small cleanups, each checked against the code:
.release-please-config.jsonbump-minor-pre-majorandbump-patch-for-minor-pre-major.gitleaks.tomlvenv/allowlist entry.venv/is the only virtualenv the repo uses and stays allowlistedpyproject.tomlE501ignoreruff check .passes without it; no example line is over 110pyproject.toml**/py.typedcoverage omit andexclude_lines = ["pragma: no cover"].pyfiles; the setting restated the defaultpyproject.toml[project.urls](Repository, Changelog, Issues)Project-URLlinesdevextrapydantic-ai-slim>=1.83.0;pytest.importorskip("pydantic_ai")becomes a plain importlangchain-coreis already indevthe same way.uv.lockgains two lines, no new packagefetch_tools(mode=...)ToolMode | Noneinstead ofAny, and documentedMIGRATION.mdNameError: name 'StackOneTool' is not definedwhen run; it runs nowscripts/validate.sh.github/dependabot.yamlignorehas no update typesTools._warn_duplicate_namesNo runtime behaviour change.
How verified
uv lock --check,uv run ruff check .,uv run ruff format --check .,uv run ty check stackone_ai examples: clean.uv run pytest(Python 3.13, all extras, MCP mock via pnpm): 871 passed, the same asmain; the pydantic-ai tests run rather than skip.uv build: wheel METADATA lists the three project URLs.NameErrorwithout the imports, runs with them.Gates (head d4f8132)
fetch_toolssignature, so d4f8132 keeps `mode: ToolModemodeannotation keeps a private type out of the signature, the dev pin mirrorslangchain-core, and droppingvenv/widens gitleaks. Raised for a decision rather than changed here: the duplicate-name warning repeats on every adapter conversion, which is existing behaviourRequested by guillaume@stackone.com in Slack (repo audit thread)
🤖 Generated with Claude Code
Summary by cubic
Cleans up stale config, fixes small doc and test gaps, and types the undocumented
fetch_tools(mode=...)argument. No runtime behavior changes.[project.urls]topyproject.tomlso the PyPI page links the repository, changelog, and issues, and drops config that was stale or restated defaults (release-please pre-major flags, thevenv/gitleaks allowlist entry, the examples per-file ruff ignores, thepy.typedcoverage omit).pydantic-ai-slimto thedevextra and replacespytest.importorskip("pydantic_ai")with plain imports, so those tests run on a dev-only install instead of silently skipping.MIGRATION.md(the 3.0 snippet raisedNameError) andscripts/validate.sh.Written for commit 960755d. Summary will update on new commits.