Repository navigation
Conversation
glebedel
marked this pull request as ready for review
November 11, 2026 10:58
glebedel
commented
Nov 11, 2026
glebedel
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed at 47ab071. No blocking issues in the workflow. The one thing that must happen before merge is the PyPI side: a stackone-ai owner has to add the trusted publisher in the table above. The GitHub side cannot confirm it, and a release merged without it fails at the upload step.
Checked
| Check | Result |
|---|---|
actionlint on release.yaml |
clean |
| Action pins | upload-artifact v7.0.2 and download-artifact v8.0.2 SHAs match their tags |
| release-please outputs | single root package ., so the unprefixed sha and version outputs the build job reads exist |
pypi environment |
deployment allowed from main only, no tag rules |
| PR build run | wheel and sdist both built, installed in isolation and reported 3.0.0 |
| Drift | 6 commits behind main, none touch .github/ or CLAUDE.md |
| Security pass (Codex, security only) | no findings. Only publish gets id-token: write, its implicit success() keeps it behind build, PR runs (fork or same repo) cannot reach the main-only environment, the source check uses the full refs/remotes/origin/main ref, caches are off and release metadata reaches the shell through env |
| CI after marking ready | all checks pass, Aikido included; publish and release-please skipped as expected |
Non-blocking suggestions
.github/RELEASING.mdmixes the evergreen release process with one-time migration steps ("Do not merge this migration until...", "Keep the existing token until the first successful publish"). After merge those lines go stale. They could live in this PR body only, or move to a short "Migrating from the API token" section that is deleted after the first trusted publish.uv publishuploads without PEP 740 attestations.pypa/gh-action-pypi-publishgenerates them by default under trusted publishing. Optional, and fine as a follow-up.- The
pypienvironment has no required reviewer, so merging a release PR publishes straight away. That matchesmaintoday, so this PR does not weaken anything. If you want a human gate on PyPI uploads, it is one setting on the environment.
After the first trusted publish succeeds, remove the PYPI_API_TOKEN secret and revoke the token, as the PR body says.
Requested by guillaume@stackone.com in Slack (repo audit thread).
🤖 Generated with Claude Code
release.yaml conflicted where main bumped action pins (#253). Kept this branch's build and publish jobs and moved every setup-uv to v10.3.3 and pnpm/action-setup to v6.1.1, including the steps this branch adds, so the file matches main's pins. No workflow logic changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing currently relies on a stored PyPI API token. This change keeps the existing Release Please flow and uploads tested artifacts using GitHub OIDC through PyPI Trusted Publishing.
The build job checks out the exact release commit, verifies it belongs to main and its package version matches the release, runs the existing test suite, and installs both the wheel and source archive in isolated environments. The separate publish job has no source checkout, downloads only its own run's artifacts, and is the only job with
id-token: write. Workflow PRs exercise the build without publishing.Required setup before merging
The current PyPI account cannot manage stackone-ai (403). A project owner must add the publisher below before this PR is merged.
stackone-aiStackOneHQstackone-ai-pythonrelease.yamlpypiThe GitHub
pypienvironment has already been configured and verified to allow only themainbranch, with no tag rules. No new secret is needed. Keep the existing token until the first successful trusted publish; then remove the unused secret and revoke the token only after checking other uses. Full release instructions are in.github/RELEASING.md.Validation and review
GitHub CI passed, including the new release build, package installation checks, and the Python test matrix. The publish job was skipped as expected on this PR. The Aikido PR check was skipped on the draft; its existing critical/high alerts were inspected separately for this diff. An actual OIDC upload is intentionally deferred until the next release; no package version or application dependencies change here.