Skip to content

ci(SEC-104): pin Node exactly in package.json devEngines - #238

Merged
glebedel merged 5 commits into
mainfrom
s2d2/sec-104-exact-node-pins
Nov 11, 2026
Merged

glebedel merged 5 commits into
mainfrom
s2d2/sec-104-exact-node-pins

Conversation

@glebedel

@glebedel glebedel commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Replaces the bare major Node versions in CI with one exact pin:

  • package.json devEngines.runtime: 22.23.4 (onFail: download), the patched release for CVE-2026-111497. It is the single source: setup-node reads it in the ci, coverage and release publish jobs (node-version-file: package.json), and pnpm downloads that exact runtime locally and in CI. The node@runtime:22.23.4 lockfile entry's integrity values match the official v22.23.4 SHASUMS256.txt (20/20 variants).
  • The conformance job runs the Node SDK, so it reads the version from stackone-ai-node/package.json devEngines (pinned to 24.22.1 in ci(SEC-104): pin Node 24.22.1 exactly in devEngines and workflows stackone-ai-node#391) instead of a second copy here.

Refs SEC-104. Requested by guillaume@stackone.com in Slack.

🤖 Generated with Claude Code

Refs SEC-104.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 17:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread .github/workflows/ci.yaml Resolved
One source per repo: devEngines.runtime 22.23.4 (onFail: download) is read by
setup-node (node-version-file: package.json) in CI and by pnpm locally, which
downloads that exact runtime and records it in pnpm-lock.yaml. The lockfile
integrity values match the official v22.23.4 SHASUMS256.txt (20/20 variants).

Refs SEC-104.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@glebedel glebedel changed the title ci(SEC-104): pin Node exactly in workflows ci(SEC-104): pin Node exactly in package.json devEngines Oct 26, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 5 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.

View guided diff | Turn on auto-fix | Re-trigger cubic

s2d2-s1 and others added 3 commits October 30, 2026 18:34
Keeps main's pnpm 11.17.0 and NODE_SDK_REF (already an exact 24.22.1
pin) and re-adds the node@runtime:22.23.4 lock entries for pnpm 11.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
pnpm-lock.yaml conflicted after main took hono 4.13.16. Rebuilt from main's
lockfile with pnpm install --lockfile-only, which adds back the node
runtime 22.23.4 entry this branch's devEngines pin needs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
The previous run failed one thread-timing test unrelated to this change
(0 failures in 40 local runs); the app token cannot re-run jobs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
@glebedel
glebedel merged commit 72afee6 into main Nov 11, 2026
13 checks passed
@glebedel
glebedel deleted the s2d2/sec-104-exact-node-pins branch November 11, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants