Repository navigation
ci(SEC-104): pin Node exactly in package.json devEngines - #238
Conversation
Refs SEC-104. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
One source per repo: devEngines.runtime 22.23.4 (onFail: download) is read by setup-node (node-version-file: package.json) in CI and by pnpm locally, which downloads that exact runtime and records it in pnpm-lock.yaml. The lockfile integrity values match the official v22.23.4 SHASUMS256.txt (20/20 variants). Refs SEC-104. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
0 issues found across 5 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.
View guided diff | Turn on auto-fix | Re-trigger cubic
Keeps main's pnpm 11.17.0 and NODE_SDK_REF (already an exact 24.22.1 pin) and re-adds the node@runtime:22.23.4 lock entries for pnpm 11. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
pnpm-lock.yaml conflicted after main took hono 4.13.16. Rebuilt from main's lockfile with pnpm install --lockfile-only, which adds back the node runtime 22.23.4 entry this branch's devEngines pin needs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
The previous run failed one thread-timing test unrelated to this change (0 failures in 40 local runs); the app token cannot re-run jobs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
Replaces the bare major Node versions in CI with one exact pin:
package.jsondevEngines.runtime:22.23.4(onFail: download), the patched release for CVE-2026-111497. It is the single source: setup-node reads it in theci,coverageand releasepublishjobs (node-version-file: package.json), and pnpm downloads that exact runtime locally and in CI. Thenode@runtime:22.23.4lockfile entry's integrity values match the official v22.23.4SHASUMS256.txt(20/20 variants).conformancejob runs the Node SDK, so it reads the version fromstackone-ai-node/package.jsondevEngines (pinned to 24.22.1 in ci(SEC-104): pin Node 24.22.1 exactly in devEngines and workflows stackone-ai-node#391) instead of a second copy here.Refs SEC-104. Requested by guillaume@stackone.com in Slack.
🤖 Generated with Claude Code