Skip to content

ci: pin conformance and stackone-ai-node to their main commits - #218

Merged
willleeney merged 1 commit into
mainfrom
ci/pin-conformance-to-main
Oct 6, 2026
Merged

willleeney merged 1 commit into
mainfrom
ci/pin-conformance-to-main

Conversation

@willleeney

@willleeney willleeney commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

CI only. Now that sdk-conformance#5, #210 and stackone-ai-node#383 are merged, the conformance job's pins move from their PR-branch commits to the merged main commits:

  • sdk-conformance 5f60cc0, whose tree is identical to the 55bd126 this repo was pinned to, so the vendored vectors still match;
  • stackone-ai-node c41b100.

They stay pinned SHAs, so a change in either repo never silently changes what this job grades.


Summary by cubic

Pins the conformance job to the merged main commits of sdk-conformance and stackone-ai-node, replacing the previous PR-branch refs now that the upstream PRs are merged. The sdk-conformance tree is identical to the old pin, so the vendored vectors still match, and both repos stay pinned to SHAs so upstream changes never silently alter what the job grades.

Written for commit a61b8fd. Summary will update on new commits.

Review in cubic Turn on auto-fix

Copilot AI balanced review requested due to automatic review settings October 6, 2026 12:24

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Auto-approved: CI-only update moving the conformance job's external repo pins from PR-branch commits to merged main commits while keeping SHA pinning. The focused workflow change carries no runtime, API, or data behavior risk.

Turn on auto-fix | Re-trigger cubic

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Both pins checked out successfully, and the vector comparison and conformance suite passed.

Review effort: Balanced
Findings: None

What changed in this PR

Updates CI conformance pins to the merged upstream commits while retaining immutable SHA references.

Changes:

  • Pins stackone-ai-node to merged commit c41b100.
  • Pins sdk-conformance to merged commit 5f60cc0.
File Description
.github/​workflows/​ci.yaml Updates conformance dependency SHAs and related comments.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@willleeney
willleeney merged commit ec7e990 into main Oct 6, 2026
@willleeney
willleeney deleted the ci/pin-conformance-to-main branch October 6, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants