Repository navigation
refactor!: execute every tool over MCP tools/call, with session ids and submit_feedback() #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
161 commits
Select commit
Hold shift + click to select a range
48ff7d9
fix(toolset): route stackone_submit_feedback over MCP and list it once
willleeney 9dda69f
feat(toolset): link calls with session_id and add submit_feedback()
willleeney f2fce60
test(mocks): serve per-action schemas verbatim from a low-level MCP S…
willleeney 2282223
fix(tools): emit the served required list in served order
willleeney 7fa339a
fix(tools): return structuredContent from a tools/call result with no…
willleeney 4fdacb0
fix(types): reduce download filenames exactly as the Node SDK does
willleeney f6dc5b3
refactor!: execute every tool over MCP tools/call
willleeney 109d729
build: drop respx, which no test uses any more
willleeney fb180a4
docs: describe MCP-only execution
willleeney 7d8bd94
fix(tools): send tools/call without relisting the catalog first
willleeney da0d1fd
ci: pin sdk-conformance to the MCP-only suite
willleeney 7d7c04a
fix(tools)!: guard every header argument by its own declaration
willleeney 16c8baa
fix(toolset): send feedback once, through the first account
willleeney 6390cc9
fix(tools)!: return the first listing from get_tool(), as Node does
willleeney a5c8b12
docs: drop the stale unwrap references and an orphaned nullable comment
willleeney fadc574
feat: export the feedback types and StackOneMcpTool, and take any seq…
willleeney 122a280
fix(toolset): move a pinned action_id and session_id to the end of th…
willleeney 2b045ad
refactor(tools): make the base StackOneTool's API key optional
willleeney 81edf7e
refactor(tools): open the MCP transport with streamable_http_client
willleeney 8d279b8
ci: check that PR titles are conventional commits
willleeney 92abaf6
docs: add a 2.x to 3.0 migration guide
willleeney dc03977
fix(tools): match a flat header argument by its exact key and forward…
willleeney 3851842
ci: pin sdk-conformance to 9b5605a
willleeney b05f232
fix(tools): treat a headers schema as open only when it is an object …
willleeney 549cf87
fix(tools): reject NaN and Infinity arguments instead of sending them…
willleeney 5a9ebfc
fix(toolset): validate submit_feedback() session_id as execute() does
willleeney a7421af
test: dispatch mock meta tools only in search_execute mode
willleeney e462ae9
test: assert an omitted required key is absent on every adapter
willleeney 0ddc28b
docs: match the README, migration guide and CLAUDE.md to what the cod…
willleeney 50246f6
fix(toolset): reject an empty account id, as Node does
willleeney 88d046b
ci: re-check the PR title when a draft is marked ready, as Node does
willleeney 883f6e5
ci: pin sdk-conformance to 6a6991d
willleeney bf2d8d5
fix(toolset): reject an empty account_id instead of widening to every…
willleeney 90508a7
fix(tools): keep the server's explanation when an MCP request fails
willleeney 4986c59
feat(tools): retry a 429 on every request, honouring Retry-After
willleeney 336b423
fix(toolset): raise a 429 that outlasts its retries instead of skippi…
willleeney 666af26
docs: document how the SDK handles rate limits
willleeney 4445836
fix(tools): end a call only on an HTTP 429, and read Retry-After as N…
willleeney eca441d
ci: pin sdk-conformance to 9d5efab
willleeney 4df82b4
fix(tools): read Retry-After as a date only when it starts with a wee…
willleeney 15f99fd
fix(tools): raise a 429 at once when its retry would outlast the dead…
willleeney 2934947
fix(tools): fall back to the backoff on a Retry-After date that overf…
willleeney f623f0c
fix(toolset): discard an account list fetched across clear_catalog_ca…
willleeney 6952f9f
fix(tools): report an MCP timeout as a timeout
willleeney 1683ea1
fix(tools): write nested header values as Node writes them
willleeney 84483bf
fix(tools): trim header names exactly as JavaScript's trim() does
willleeney 2991836
fix(toolset): reject a non-string account id
willleeney f29e31b
fix(tools): raise ToolArgumentsError for unusable tool arguments
willleeney 30341e1
fix(types): declare ToolParameters.required
willleeney e9fb912
fix(examples): build the call from example_request and tolerate a non…
willleeney 948cf67
docs(examples): list every example that needs STACKONE_ACCOUNT_ID
willleeney b4354e6
docs(migration): say that an empty account id now raises
willleeney 797f6df
fix(headers): drop a non-object headers argument unless declared, and…
willleeney 6a3cbb3
ci: pin sdk-conformance to 67103ca
willleeney d8a5ebb
fix: raise ToolArgumentsError on self-referential header values
willleeney 35da92d
fix: avoid caching a catalog resolved before a mid-discovery cache clear
willleeney 1c42c1f
docs: narrow MIGRATION.md header claims
willleeney 5a466cc
feat(toolset): read STACKONE_BASE_URL
willleeney a965484
fix(toolset): share one in-flight GET /accounts across concurrent dis…
willleeney 2e58b2f
docs: document every ToolArgumentsError site in its docstring and MIG…
willleeney 3ddf966
docs: note that integers above 2^53 keep their exact value, unlike Node
willleeney 80be144
fix(tools): read Retry-After as a strict RFC 9110 HTTP-date
willleeney b6c0ce6
fix(tools): refuse NaN in argument JSON text, and compare SDK-owned h…
willleeney dbe74a1
fix(toolset): refuse a non-list account_ids with ToolsetConfigError
willleeney fd39798
fix: align error and warning messages with the Node SDK
willleeney 700314e
fix(tools): word the 429 deadline warning as the Node SDK does
willleeney 72a5ef2
test(vectors): vendor sdk-conformance's shared vectors at b8c2871
willleeney 37b0047
test(vectors): grade the SDK against every shared vector
willleeney 2fd4e73
ci: fail when tests/vectors differs from the pinned sdk-conformance
willleeney 1f80e0f
test(vectors): sync the shared vectors to sdk-conformance daf1140
willleeney 6a7db6c
ci: pin sdk-conformance to daf1140
willleeney f3f1fd6
fix(toolset): reject tuple account ids and raise instead of assert
willleeney f1173de
fix(tools): avoid OverflowError on a leap-second Retry-After at the m…
willleeney 8147881
test(fetch_tools): synchronize the concurrent discovery failure test
willleeney 9782676
fix(scripts): harden sync_vectors.sh
willleeney a9d7cd8
test(vectors): sync the shared vectors to sdk-conformance 0906f4d
willleeney 63a4dd7
ci: pin sdk-conformance to 0906f4d
willleeney 731218a
docs(migration): an ordinary headers field still passes the JSON-valu…
willleeney c334066
test(vectors): sync the shared vectors to sdk-conformance dfdaca1
willleeney ea69dd3
ci: pin sdk-conformance to dfdaca1
willleeney ae0c43f
test(vectors): sync the shared vectors to sdk-conformance ee0bb06
willleeney 95748bd
ci: pin sdk-conformance to ee0bb06
willleeney 9b3bbea
fix(tools): let KeyboardInterrupt and SystemExit through an MCP request
willleeney f072fe8
build: require langchain-core 0.3.36 or later for a dict args_schema
willleeney 949a01f
fix(toolset): read a root type that is not a string as object, as Nod…
willleeney c363f28
fix(tools): return non-text content parts as plain JSON, as Node does
willleeney 249957b
fix(tools): report a timeout on a request retried after a 429 as the 429
willleeney c17bf6b
fix(toolset): cache the healthy accounts when one fails, and keep eve…
willleeney f82acd3
feat(toolset): tag each search hit with its account_id and apply top_…
willleeney 47846af
fix(toolset): refuse an action whose connector is linked on more than…
willleeney 1d8ddcd
test(toolset): pin the session_id move and the SDK-owned header filter
willleeney ee83c44
fix(tools): build every adapter from the first tool of each name
willleeney 959bcc8
feat(toolset): warn when STACKONE_ACCOUNT_ID is set but ignored
willleeney 1047753
feat(toolset): add action_run_id to submit_feedback, and send it thro…
willleeney 89e647c
docs: describe account_id on search hits, top_k across connectors and…
willleeney 6288a3a
ci: run the full conformance suite against the Node SDK too
willleeney 82dcb6b
fix(toolset): raise an all-accounts failure from an ExceptionGroup of…
willleeney 666877c
test(vectors): sync the shared vectors to sdk-conformance ec4dcfb
willleeney 9581aa3
ci: pin sdk-conformance to ec4dcfb
willleeney 54a2260
fix(tools): word a timeout after a retried 429 as Node does
willleeney 2cdac07
test(vectors): grade the 429-timeout messages
willleeney 54322a3
ci: pin sdk-conformance to db6b908
willleeney e3139c2
fix(tools): clear the throttle marker after a 429 retry succeeds
willleeney 486ab4c
docs(migration): qualify the partial-catalog and account-id-warning w…
willleeney 66fb7be
ci: pin the Node SDK checkout to a commit SHA
willleeney b1b695b
fix(toolset): warn for STACKONE_ACCOUNT_ID even with an empty account…
willleeney a1095c0
fix(toolset): merge concurrent catalog updates instead of overwriting
willleeney b9743df
docs: pass account_ids in the feedback-section and CLAUDE.md execute(…
willleeney d7696d8
chore(vectors): sync shared vectors to sdk-conformance 2f4a655
willleeney 7e9b3ef
test(vectors): sync to sdk-conformance c794e56, where messages.json s…
willleeney e2ea2c2
ci: run conformance against stackone-ai-node 00da255
willleeney cf3f620
feat(toolset): send x-end-user-id for non-shared accounts
willleeney 27c0dfd
test(vectors): sync to sdk-conformance f46905f, where x-end-user-id i…
willleeney 9d81979
feat(toolset): add a headers option sent on every request, as Node has
willleeney b342550
docs: describe the toolset headers option
willleeney ea540f8
ci: pin sdk-conformance to 0d72282
willleeney c816fe9
test(vectors): sync to sdk-conformance 88c9400
willleeney 6ad8c25
ci: pin sdk-conformance to 88c9400
willleeney 508ee6e
ci: run conformance against stackone-ai-node 8030159
willleeney 2a4b192
fix(mocks): resolve x-account-id from the query string under MOCK_END…
willleeney e19c351
test(toolset): assert explicit account ids make no GET /accounts request
willleeney 0c1174d
fix(toolset): order overlapping fetch_accounts() records by start time
willleeney 599be45
docs: fetch_accounts() records end users in start order
willleeney 658571a
test(end-user): surface failures from the racing fetch_accounts() thr…
willleeney d87ecd1
test(vectors): sync to sdk-conformance 7347926
willleeney b9d0b5f
ci: pin sdk-conformance to 7347926
willleeney d307ed8
ci: run conformance against stackone-ai-node c2b8736
willleeney f0a8acb
fix(toolset): address the second review on multiple and non-shared ac…
willleeney 64d1dcd
docs: describe non-shared discovery, the failed-account refusal and t…
willleeney a7c6960
fix(toolset): quote the action id in the failed-account error, as Nod…
willleeney bddfcf0
test(vectors): sync to sdk-conformance python-198-examples f36bb79 an…
willleeney 7db755c
ci: run conformance against stackone-ai-node c5f2537
willleeney 3872385
fix(toolset): refuse only for a failed account on the action's own co…
willleeney d178117
ci: pin sdk-conformance to 27796bb
willleeney 8ab4a17
ci: run conformance against stackone-ai-node 9d332ab
willleeney 2c338b1
fix(toolset): re-list only the failed accounts that could serve the a…
willleeney 084322b
fix(toolset): learn a failed account's provider with one GET /account…
willleeney 70007de
fix(toolset): chain a failed end-user lookup onto the 400 it was look…
willleeney a940f34
fix(toolset): raise when every active account discovery finds is non-…
willleeney 0abe0c0
fix(toolset): say the toolset uses every active shared account, and t…
willleeney 748ae08
fix(tools): keep a retried 429 on record while another request in the…
willleeney e70161e
test(toolset): an account that fails during an execute() is not liste…
willleeney f5cebbf
test(vectors): sync to sdk-conformance 7369b74, with a no-shared-acco…
willleeney 276da2e
ci: pin sdk-conformance to 7369b74
willleeney 80b580b
ci: run conformance against stackone-ai-node 9d7f2af
willleeney d6739a9
test: stub GET /accounts in the same-call re-list test, and bound the…
willleeney 7f1835b
docs: a failed account on another provider is listed again when due, …
willleeney 33dc91c
ci: pin sdk-conformance to ddd2074
willleeney b9bf8ea
ci: run conformance against stackone-ai-node 023dbea
willleeney a8b825c
test: refuse any connection beyond loopback, and stub GET /accounts i…
willleeney aefa3cd
test: say the connector-account-unavailable vector's lookup does a GE…
willleeney 044153c
test: pin that execute() raises a rate-limited provider lookup
willleeney 8ed9cc7
fix: hold a provider lookup's miss for the failed-account window, so …
willleeney f5f4d51
ci: pin sdk-conformance to 960a542
willleeney 970d7b8
ci: run conformance against stackone-ai-node 92b23de
willleeney 91e0a3a
fix(toolset): act on a provider-lookup miss in the call that made it,…
willleeney 9a84c2b
ci: run conformance against stackone-ai-node dbee8bd
willleeney 5f91933
ci: pin sdk-conformance to 55bd126
willleeney eeef2c0
ci: run conformance against stackone-ai-node 2253466
willleeney 9a35e2e
test: pin the network guard's refusal, not the name it sees
willleeney 441a0ca
test(toolset): a provider-lookup miss is forgotten once GET /accounts…
willleeney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: 'Check PR title' | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - reopened | ||
| - edited | ||
| - synchronize | ||
| - ready_for_review | ||
|
|
||
| permissions: | ||
| pull-requests: read | ||
|
|
||
| jobs: | ||
| main: | ||
| name: Validate PR title | ||
| runs-on: ubuntu-slim | ||
| steps: | ||
| - uses: amannn/action-semantic-pull-request@48f256284bd46cdaab1048c3721360e808335d50 # v6.1.1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| ignoreLabels: | | ||
| autorelease: pending | ||
| dependencies | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.