Repository navigation
test(tool): pin the MCP server's input rule keywords through every adapter - #417
Merged
Merged
Conversation
…apter The MCP server now advertises each connector input's validation rules as JSON Schema keywords (minLength/maxLength, format, pattern, minimum/maximum, also on array items). Every adapter already passes the served schema through; this pins that each one keeps those keywords, so a later schema cleanup cannot drop them without a failing test. The adapter list is shared with the root pass-through tests through adaptersFor(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
commit: |
Review: the served required list is part of what reaches the model, and a re-sorted or dropped required list has shipped before in the Python SDK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minLength/maxLength,format,patternandminimum/maximum, including on array items. They appear in individual-modetools/listand in search results.tools/listnow serves goes through each provider adapter (toOpenAI,toAnthropic,toOpenAIResponsesstrict and non-strict,toAISDK), and the test asserts every keyword and therequiredlist arrive intact.toClaudeAgentSdkserves thetoAnthropicschema, so it is covered too.adaptersFor(tool), shared with the existing root pass-through tests.Test plan
vitest run src/tool.test.ts: 159 pass, including the 5 new cases and the type test.oxfmt --checkandoxlintare clean on the changed file.🤖 Generated with Claude Code
Review gates and proof
Recorded by s2d2 on
014f3db.