Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,37 +53,6 @@ jobs:
with:
severity: warning

extensions:
name: validate + test extensions
runs-on: ubuntu-latest
steps:
# Full history: the version check resolves a merge base, which the
# default shallow clone does not contain.
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
with:
fetch-depth: 0

# Curation is the security model for extensions, and a reviewer reads a
# diff — which does not show where a symlink points. This is the part of
# the review a human cannot reliably do by eye.
- name: validate
run: ./scripts/package-extensions.sh validate

# The same script `make test-extensions` runs, so the gate and the local
# loop cannot drift.
- name: test extensions
run: ./scripts/test-extensions.sh

# A changed extension that keeps its version is published as an update
# nobody can get: the app compares version strings to decide one exists,
# so republishing under the old number reaches no one who already
# installed it.
- name: check extension versions
if: github.event_name == 'pull_request'
run: |
git fetch --no-tags origin "${{ github.base_ref }}"
./scripts/check-extension-versions.sh "origin/${{ github.base_ref }}"

build-macos:
name: swift build (${{ matrix.arch }})
runs-on: macos-15
Expand Down
7 changes: 0 additions & 7 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,3 @@ venv/
/tmp/
*.log
keys/
# The Pylon extension's cache, written beside it when run from a checkout. It
# holds customer account names, issue links and message previews.
extensions/pylon/state.json*
# Extensions that compile themselves on first run (away) build into .build/
# beside their source. Already covered by .build/ above; named here so it
# survives anyone narrowing that line to the root.
extensions/*/.build/
7 changes: 0 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,6 @@ typecheck-tests:
test-without-xcode:
@./scripts/run-tests-without-xcode.sh $(NAME)

# The reference extensions' own tests, the same way CI runs them. They are
# Python rather than XCTest because the extensions are — nothing in an
# extension is Swift, and a script's tests belong beside the script.
.PHONY: test-extensions
test-extensions:
@./scripts/test-extensions.sh

# One-shot dev cycle: rebuild, reinstall the app, refresh notify.sh in
# ~/.stack-nudge so hook-side changes propagate, kickstart the daemon.
# Build output goes to $(BUILD_LOG); on failure, last 20 lines tail to stderr.
Expand Down
1 change: 0 additions & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ let package = Package(
"phrases",
"hooks",
"docs",
"extensions",

// Tests own this directory; declare here so SPM doesn't
// sweep the test sources into the library target.
Expand Down
3 changes: 2 additions & 1 deletion Tests/StackNudgePanelCoreTests/AwayPresenceTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import XCTest

// The app's half of Away: what the presence signal makes it do, and the
// Settings row that decides whether leaving locks the screen. The detection
// itself is extensions/away, tested by its own suite.
// itself is the away extension, tested by its own suite in the extensions
// marketplace.
final class AwayPresenceTests: XCTestCase {

func testAwayLocksOnlyWhenTheSettingSaysTo() {
Expand Down
14 changes: 8 additions & 6 deletions docs/extensions.md
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,8 @@ these?" is a question the reference should answer. Any `extensions/*/test_*.py`
is run by CI and by `pnpm check` there; a suite that discovers zero tests is
a failure rather than a pass.

`scripts/package-extensions.sh validate` is what CI runs, and you can run it
yourself. It refuses:
`scripts/package-extensions.sh validate`, in the marketplace and in every catalogue made from
the template, is what CI runs, and you can run it yourself. It refuses:

- a manifest that doesn't parse, or whose `id` disagrees with the directory name
- an `id` outside `^[a-z0-9][a-z0-9-]{0,31}$`, or a `schema` that isn't 1 or 2
Expand Down Expand Up @@ -434,8 +434,10 @@ those hosts can't read any catalogue without it.

A team can publish its own extensions from another repository, a private one
included, and have them show up in the browser next to these. The repository
publishes exactly what this one does: run `scripts/package-extensions.sh` and
attach the index, the packages and their sidecars to its latest release. Then
publishes exactly what the marketplace does, and the simplest way is to make it
from [StackOneHQ/stack-nudge-extensions-template](https://github.com/StackOneHQ/stack-nudge-extensions-template),
whose release workflow attaches the index, the packages and their sidecars to
its latest release. Then
each person who wants it adds the repository under **Settings → Extensions →
Other catalogues**, which writes it to `~/.stack-nudge/config`:

Expand Down Expand Up @@ -479,7 +481,7 @@ hardware capabilities such as `bluetooth`. The full table is in the design
note, under "Privilege tiers".

The tier is the reviewers' call, not the extension's, so it lives outside the
package, in `extensions/tiers.json`:
package, in the catalogue's `extensions/tiers.json`:

```json
{ "away": "trusted" }
Expand Down Expand Up @@ -586,7 +588,7 @@ empty list, is refused.

## Away, the reference service extension

`extensions/away` notices when you walk away from the Mac with your phone, and
`extensions/away` in StackOneHQ/stack-nudge-extensions-marketplace notices when you walk away from the Mac with your phone, and
sets the app's `presence` signal. It is the one to read when writing a service:

- **`manifest.json`** asks for `bluetooth` and `signal:presence`, both
Expand Down
2 changes: 0 additions & 2 deletions docs/setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ make dev # watch sources; auto-reload on .swift / Info.plist / n
make test # swift test (needs full Xcode for XCTest)
make test-without-xcode # compile and run the tests with the Command Line Tools only
make test-notify # drive notify.sh against a fake panel socket (macOS, no Xcode)
make test-extensions # validate and test the bundled extensions
make uninstall # remove app, hooks, launchd agents, ~/.stack-nudge/
```

Expand All @@ -115,7 +114,6 @@ Source layout:
- `hook-manifest.json` — which agent events get wired to `notify.sh`
- `hooks/` — the Claude Code plugin hooks and the pi extension
- `phrases/` — per-language voice phrase pools sourced by `notify.sh` at hook time
- `extensions/` — the extensions in the catalogue; see [extensions.md](extensions.md)
- `shared/` — code shared with the Linux/Windows surfaces
- `scripts/`, `Tests/` — release and packaging scripts, and the test suite

Expand Down
Loading
Loading