Repository navigation
feat(extensions): read the app's catalogue from the extensions marketplace - #258
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step of moving the built in extensions out, the marketplace itself is StackOneHQ/stack-nudge-extensions-marketplace#1. Don't merge this until that's merged and has published its first release - the app fails the whole catalogue if its own one can't be read.
ExtensionSource.builtInis now the marketplace, soreleaseJSON()reads its latest release (anonymous then the gh fallback, same as before) and it's the catalogue that can grant up to trusted.StackOneHQ/stack-nudgeitself becomes an ordinary extra source held to view, if anyone names itextensions/is still here but nothing publishes from it, the next PR takes it out. Full suite passes locally (1803), thebuild.shbuild too.