Skip to content

feat(ENG-3220): show only the notice for apps linked at sign-in - #249

Draft
jpmiguel wants to merge 3 commits into
mainfrom
handover/eng-3220-hub-linked-at-sign-in
Draft

jpmiguel wants to merge 3 commits into
mainfrom
handover/eng-3220-hub-linked-at-sign-in

Conversation

@jpmiguel

Copy link
Copy Markdown
Contributor

Copy of #214, originally opened by bgrcs (original state: draft), kept as a handover in case the original is lost. Snapshot of bruno/eng-3220-hub-linked-at-sign-in at f7ea5fa6f0c5589246cf73f47f88780172a99723. Review threads stay on the original.

Context

With Okta account linking (XAA), an employee's accounts on some apps are linked by the identity provider when they sign in to StackOne. The Hub has nothing to connect for them (ENG-3220).

Today a member who opens one of those apps sees:

  • The API's notice: "Accounts for this app are linked automatically when you sign in to StackOne through your company's SSO, so there is nothing to connect here".
  • "Press Connect below to authenticate" right under it.
  • A Connect button that the API refuses with a 422.

Changes

The API now sends linkedAtSignIn: true on those configs (StackOneHQ/unified-cloud-api#9206). With it:

  • The no-fields view shows the notices and drops the "Press Connect" prompt.
  • The footer shows no actions, as on the list view.
  • The title's back arrow stays, so the user can return to the list.

Configs without the flag render exactly as before.

Testing

  • Checked in a build of this branch against a local API. An Okta-linked option shows the notice with no Connect button, and a normal connector still shows its form and Connect button.
  • The Hub has no component tests yet. npm run lint and npm test pass on a clean npm ci.

After release

  • The dashboard needs a @stackone/hub bump.

Summary by cubic

Shows only the automatic-linking notice for apps whose accounts are linked at sign-in, instead of prompting users to connect and letting them hit a Connect action that errors with a 422.

  • Uses the API's linkedAtSignIn flag on connector configs to hide the "Press Connect below to authenticate" prompt and the footer actions; Back stays so users can return to the list.
  • The flag is read directly from the narrowed config in the fields memo and threaded through the view components.
  • Configs without the flag render exactly as before.

Written for commit f7ea5fa. Summary will update on new commits.

View guided diff Turn on auto-fix

bgrcs added 3 commits October 7, 2026 18:36
An app whose accounts the identity provider links at sign-in (Okta Cross
App Access) has nothing to connect, but the no-fields view still said
"Press Connect below to authenticate" under the API's "linked through SSO"
notice, and Connect only returned an error. When the API marks the config
linkedAtSignIn, the Hub shows the notice alone and drops Connect. Back
stays, so the user can return to the list.
…arrowed

The fields memo already narrows to a Falcon config, so it carries the flag
and the separate type guard goes. The footer builds its buttons as one
array instead of pushing onto a mutable one.
…tton

The title's back arrow shows under the same conditions as the footer's Back,
so an app linked at sign-in can drop the footer actions like the list view
does, with no new prop on CardFooter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants