Repository navigation
ci(workflow): pin Node in package.json devEngines instead of .nvmrc (SEC-104) - #241
Conversation
One source per repo: devEngines.runtime 22.23.4 (onFail: warn) is read by setup-node (node-version-file: package.json) in CI. Refs SEC-104. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Keeps this branch from reintroducing a pre-fix Node when it merges. https://nodejs.org/en/blog/vulnerability/november-2026-security-releases Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
glebedel
left a comment
There was a problem hiding this comment.
Review at head 5a6caac6 (Node Nov 2026 security release, SEC-104).
- Correctness (Codex pass over all 68 bump PRs): OK. Pins in this repo agree; no stale 22.23.4 / 24.22.1-2 / 26.12-13.0 left in the diff.
- Security (Codex security-only pass): no findings. Lockfile node runtime URLs and hashes match the official SHASUMS256; no workflow permission or action-pin changes.
- CI: all 5 checks green on this head.
- Open review threads: 0.
Ready to merge from my side. GitHub approval still has to come from a person: s2d2 cannot approve PRs, and in this repo s2d2 acts with the same identity that opened the PR.
Requested by guillaume@stackone.com in Slack (#C05LDDNTJKV thread 1793813777.685889).
Resolves the .nvmrc conflict with the Nov 2026 Node bump: the pin lives in package.json devEngines.runtime on this branch, so .nvmrc stays deleted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What
.nvmrctopackage.jsondevEngines.runtimeand deletes.nvmrc.node-version-file: package.json. setup-node v6.3 and later readdevEngines.runtimebeforeengines.node, so CI gets the exact version, not the newest match of theenginesrange.onFail: "warn": npm warns on a mismatch instead of failing, so a local Node that is a patch behind is flagged without blocking work. CI stays exact through setup-node.Why
One place for the Node version, read by CI and by the package manager.
.nvmrcis only read by nvm and setup-node, and anenginesrange alone would let CI float to whatever release is newest. Docker base images are pinned separately and are unchanged.Local verification
Refs SEC-104. Requested by guillaume@stackone.com in Slack.
🤖 Generated with Claude Code
Summary by cubic
Pins the November 2026 Node security release (22.23.5) in
package.jsondevEngines.runtimeand deletes.nvmrc, so CI and npm read one source of truth for the Node version.node-version-fileatpackage.json;setup-nodereadsdevEngines.runtimebeforeengines.node, so CI installs the exact pinned version.onFail: "warn"flags a patch-behind local Node as a warning without blocking work.Written for commit f832cc0. Summary will update on new commits.