Repository navigation
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Auto-approved: Dev-only upgrade of the two React sandboxes to TypeScript 7.0.2, with JSX augmentation moved into React's namespace and a new sandbox CI workflow; no library/runtime changes and both compilers pass the validated builds.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: Dev-only upgrade of the two React sandboxes to TypeScript 7.0.2 with npm lockfile updates, plus moving the JSX augmentation into React's namespace; no library or runtime changes.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
Conflict refresh against main
The earlier compiler timings are historical measurements of the explicitly recorded graph, not new measurements of the expanded current main. Published signed merge: The published refresh passes the existing root CI run: normal npm ci, full build and verification, lint, and all 32 tests. Aikido reports no new security issues on this head. @cubic-dev-ai review this PR |
@glebedel I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 5 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Dev-only upgrade of two React sandboxes to TypeScript 7.0.2 with lockfile updates and the JSX augmentation moved into React's namespace; no runtime, library, or CI changes, so risk is confined to sandbox type-checking.
View guided diff | Turn on auto-fix | Re-trigger cubic
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
s2d2 fix pass (requested by guillaume@stackone.com in Slack): merged main into the branch (12 commits behind, CI had not run). Only the dev sandboxes changed, so CI exercises nothing new here. |
Upgrade the existing
tsc --noEmitstage in the React web-component and React 19 sandboxes to TypeScript 7.0.2. Keep the library compiler and the Angular, Next.js and Vue compiler integrations unchanged.CI scope: this PR introduces no workflows or jobs. The compiler-migration workflow additions have been removed, and pre-existing workflows are unchanged. This deletion changes no compiler, dependency graph, source or benchmarked command, so the recorded performance measurements remain applicable. Hosted results and bot reviews below refer to the earlier commits explicitly linked; they are not claims about the cleanup commit. The cleanup independently passed diff/reference checks and a scoped security/Forge review. Hub's existing
npm run lintalso passed after deletion.The React web-component sandbox already failed under TypeScript 5.9.3 because its custom element augmented the old global JSX namespace. This PR moves that same declaration, with all property types preserved, into React’s JSX namespace. Both compilers pass on the identical repaired final source. No runtime expression or compiler configuration changes.
Both sandboxes now have npm lockfiles for reproducible
npm ciinstalls. The React lock was generated with npm after review identified that its previous unlocked install could drift between runs. The migration-only sandbox workflow has been removed; the existing root workflow is unchanged.Measured compiler performance
Node 22.22.0 on a 14-core macOS host; two warmup rounds followed by seven measured rounds, alternating compiler order. All 36 compiler invocations passed. Both compilers use the final locked dependency graph and identical repaired source.
tsc --noEmittsc --noEmitOne-minute host load ranged from 8.03 to 8.79 on 14 cores. These are local observations, with no claim of a completely idle host. Other audit jobs were paused; unrelated user processes were not stopped. These are compiler-process measurements, not an end-to-end build or CI speedup. No incremental cache is configured. OS/package caches remained warm; package-manager startup, dependency installation, library bundling and Vite are excluded.
Reproduce with the baseline 5.9.3 compiler and candidate 7.0.2 compiler installed separately: from each sandbox directory, time
node /absolute/path/to/compiler/bin/tsc --noEmitagainst the same checkout and dependencies. Use two warmups and seven measured rounds, alternating compiler order. The benchmark driver, exact compiler paths, independent version checks, and raw samples are retained in the audit workspace.dev/reactsamples in seconds:dev/vite-react19samples in seconds:Measurement correction: final audit found that the earlier driver invoked the root TypeScript 5.8.3 executable while labeling it 5.9.3. Those two runs are retained and explicitly marked superseded; neither is used in the table above. The corrected driver selects the original sandbox’s exact 5.9.3 executable, asserts actual
--versionoutput for every selected compiler before sampling, and repeats both scope/build validation and timing. The final numbers above replace all earlier PR numbers.Validation and boundaries
npm testwrapper hit a sandbox IPC restriction in thetsxlauncher; equivalent direct invocation passed, and the first hosted CI round subsequently passed the ordinarynpm testcommand.npm ci, full library build, build verification, lint and all 26 tests.npm installand React 19npm ci; the final follow-up head passed normalnpm cifor both sandboxes (68 and 75 installed packages on Linux), followed by their complete compiler and Vite builds.Independent security and Forge review passed for both the initial change and the lock/workflow follow-up. All 133 new registry lock records matched official cached publisher metadata, including tarball/SRI, dependency and optional edges, platform restrictions, engines and executable declarations. No compiler or platform package introduces an install hook. The new sandbox lock fixes its previously unlocked dependency selection; it is not a broad dependency-security remediation. Previous-head root and sandbox CI, semantic title and Aikido all passed. Cubic approved a781829 with zero new findings (review 5477395473); its original lockfile finding was fixed, answered, and automatically resolved by Cubic. The agent did not resolve the thread.
Audit evidence:
continuation/evidence/hub-sandboxes/benchmark.json,locked-react-validation.json,scope-parity.json,candidate-gates.json, andcontinuation/benchmark_hub_sandboxes.py. The original-source baseline failure remains explicit. Framework probes are recorded separately: the exact Vue compiler rejects native TypeScript’s missinglib/tscAPI; Next.js’ actual prerequisite helper rejects its missinglib/typescript.js. Angular 18’s upstream version guard rejects 7.0.2. Their existing checks are preserved.The repository security overview showed code scanning needing setup, secret scanning enabled, and Dependabot enabled with 84 pre-existing default-branch alerts (2 critical, 50 high, 29 moderate, 3 low). No code-scanning pass or full-graph vulnerability-free claim is made. Aikido passed on the previous PR head and reported no new issues. Automatic Copilot review was unavailable because its quota was exhausted; no manual retrigger was requested.
Hosted evidence: root build, lint and 26 tests, React locked install and build, and React 19 locked install and build.
Scope clarification for automated review summaries: this PR upgrades only the two React sandboxes. The root library’s TypeScript 5.8.3 and Angular’s TypeScript 5.5 series remain unchanged. The JSX namespace issue also failed under the original sandbox TypeScript 5.9.3; it was not introduced solely by TypeScript 7.