Repository navigation
Conversation
There was a problem hiding this comment.
No issues found across 4 files
Auto-approved: Dev-only change: root lint typecheck switches from TS 5.8 to native TS 7 via a dedicated tsconfig and new devDependency, with a measured 5x speedup; build, runtime, and production dependencies are unchanged.
View guided diff | Turn on auto-fix | Re-trigger cubic
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
s2d2 fix pass (requested by guillaume@stackone.com in Slack): merged main into the branch (it was 27 commits behind and had never run CI), npm run lint passes locally with the native TypeScript 7 typecheck. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the stable native TypeScript 7.0.2 compiler for Hub's existing root lint typecheck. The median compiler check falls from 0.706165s to 0.134239s, 80.99% less time (5.26×), saving 0.571926s per invocation locally.
TypeScript 5.8.3 remains installed for
@rollup/plugin-typescriptandrollup-plugin-dts, which use its JavaScript compiler API. The lint script invokes the exact@typescript/nativealias explicitly because both packages exposetsc. The root build configuration, application source, Biome commands, production dependencies and CI permissions are unchanged.The check-only config uses
moduleResolution: bundlerbecause native TypeScript no longer supports the oldNoderesolver. Its explicittypeslist preserves all eleven baseline-visible ambient type packages. Both compilers cover the same 43 project files; every baseline@typesdeclaration file remains included. Compiler library differences account for 397 versus 400 total files. An initial narrower ambient configuration was caught in independent review and corrected before the final benchmark.Benchmark
Baseline commit:
4dc2d0fdd212e096802ec5f3a9eb1ff01e374705. Same final source/dependency tree on macOS arm64, Node 22.14.0 (the CI version), TypeScript 5.8.3 versus 7.0.2. Two unmeasured warmups per compiler, then seven alternating pairs; 18 subprocesses all exited zero. Each check is nonincremental, with warm filesystem caches. Package-manager startup and dependency installation are excluded. Other audit agents were idle during measurement; the host can still have unrelated background work. Load averages were[3.2900390625, 5.05810546875, 11.0859375]before and[3.85986328125, 5.12158203125, 11.03759765625]after.Reproduce after
npm cion this branch with the same Node executable. Confirm the two versions, warm each command twice, then time seven alternating pairs and reject any failed process:The saving applies to this compiler check, not total CI time, emitted-build performance or browser runtime. Nested development packages are separate compiler jobs and are outside this root change.
Local validation
npm run lintpasses: both existing Biome checks cover 97 files and the native typecheck succeeds. The legacy compiler also passes on final source.node --import tsx scripts/check-format-vectors.tsand the Vitest CLI) to avoid the local tsx launcher IPC limitation.verify:buildpasses, including bundle version stamps.npm cicompleted; hosted CI must validate the real npm lock/install.Security and review
Independent security and whole-diff Forge reviews found no remaining issues. All 351 prior lock package records are unchanged. The only additions are the exact official TypeScript 7.0.2 alias and its 20 optional platform packages; publisher integrity, platform/engine metadata and absence of new lifecycle hooks were checked. Existing legacy API consumers still resolve TypeScript 5.8.3. No application, authentication, SSR, bundle side-effect, publishing or workflow permissions changed. This review does not certify inherited dependencies vulnerability-free.
Hosted validation and final review
The existing Linux CI build passed on head
469e76caf8b378bd84ee73f651aa14a8d1f86766, using Node22.14.0/npm10.9.2: normalnpm ci, full Rollup build with successful process exit, bundle verification, both Biome checks plus native TypeScript, and all26 tests. This closes the normal install/build gate while leaving the inherited macOS watcher limitation above explicit. The npm audit reported12 inherited vulnerabilities (8high,4moderate); those package-path counts differ from default-branch Dependabot alerts below.Cubic approved with no findings across all4files. There are no inline review comments. Aikido and PR-title checks passed. Automatic Copilot failed because review quota was exhausted and performed no review; it was not manually retried. Build/test CI is green, but this quota failure prevents saying every check is green.
GitHub Code scanning reports Needs setup; Secret scanning and Dependabot are Enabled. No scanner configuration or alert disposition was changed. Independent security review and final whole-diff Forge are complete, with no outstanding findings.
GitHub reported 84 existing default-branch Dependabot alerts at push time (2 critical, 50 high, 29 moderate, 3 low). The prior dependency records remain unchanged; these inherited alerts have not been remediated or suppressed here.
Summary by cubic
Switches the root lint typecheck to the native TypeScript 7.0.2 compiler via the
@typescript/nativealias, cutting median check time from 0.706s to 0.134s (~5.3× faster). TypeScript 5.8.3 stays installed for@rollup/plugin-typescriptandrollup-plugin-dts, which rely on its JavaScript compiler API. The lint script now invokes the native binary explicitly since both packages exposetsc.tsconfig.typecheck.jsonusingmoduleResolution: bundler(native TypeScript dropped the oldNoderesolver) and an explicittypeslist preserving all eleven ambient type packages.AGENTS.md; existing lock package records are unchanged, and the merge frommainintroduces no further changes.Written for commit e7466a2. Summary will update on new commits.