Repository navigation
Conversation
Refs SEC-104. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
setup-node defaults check-latest to false, so a floating 22 can resolve to a cached Node 22 older than 22.23.4. Addresses review feedback. Refs SEC-104. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.
View guided diff | Turn on auto-fix | Re-trigger cubic
Workflows pinned Node separately from the repo's own version source, so every Node bump had to be made twice. setup-node now reads node-version-file: package.json, which makes package.json the only place to change. - volta.node goes from 20.18.1 to 22.23.4 to match what CI already runs. - .github/workflows/node-ci.yml: 1 step (was 22.23.4). - .github/workflows/release-please.yml: 1 step (was 22.23.4). Requested by guillaume@stackone.com in Slack. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Added a9a5a10: workflows now read
Requested by guillaume@stackone.com in Slack. |
There was a problem hiding this comment.
0 issues found across 3 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Bump CI and Volta Node from 20.18.x to 22.23.4 to fix CVE-2026-111497; workflows now read the version from package.json. Only version pins and the version-file mechanism change, no workflow logic, and PR CI exercises the new version.
View guided diff | Turn on auto-fix | Re-trigger cubic
Keeps this branch from reintroducing a pre-fix Node when it merges. https://nodejs.org/en/blog/vulnerability/november-2026-security-releases Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
glebedel
left a comment
There was a problem hiding this comment.
Review at head a07f07d8 (Node Nov 2026 security release, SEC-104).
- Correctness (Codex pass over all 68 bump PRs): OK. Pins in this repo agree; no stale 22.23.4 / 24.22.1-2 / 26.12-13.0 left in the diff.
- Security (Codex security-only pass): no findings. Lockfile node runtime URLs and hashes match the official SHASUMS256; no workflow permission or action-pin changes.
- CI: all 4 checks green on this head.
- Open review threads: 0.
Ready to merge from my side. GitHub approval still has to come from a person: s2d2 cannot approve PRs, and in this repo s2d2 acts with the same identity that opened the PR.
Requested by guillaume@stackone.com in Slack (#C05LDDNTJKV thread 1793813777.685889).
vite 8 / rolldown native bindings need Node 20.19+ or 22.12+; CI was pinned to 20.18.x. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Moves file-picker off Node 20 (end of life) onto Node 22.23.5, the November 2026 Node security release, matching the rest of the org.
package.jsonvolta.nodeis now the single source of truth: both workflows read it withnode-version-file: package.json, so CI, the release build and local Volta users all run the same version.What changed
package.jsonvolta.node20.18.122.23.5.github/workflows/node-ci.ymlnode-version: '20.18.x'node-version-file: package.json.github/workflows/release-please.ymlnode-version: '20.18.x'node-version-file: package.jsonNo library code changes. There is no
enginesfield,.nvmrc, Dockerfile or doc that pins Node, so nothing else says 20.x. The CI log on this head showsResolved package.json as 22.23.5andnode: v22.23.5.Evidence
Dogfood at the PR head: a scratch consumer app installs the
npm packtarball, is built on Node 22.23.5, opens the picker, selects two files and getsonFilesPicked, then opens it again and cancels. The picker iframe points at a local mock ofapp.stackone.com/embedded/files_pickerthat logs what the SDK sends (token masked) and what it posts back, because the real page needs a StackOne session token.Full recording (mp4) · mock log
Before (main, Node 20.18.1) on the left, after (this PR, Node 22.23.5) on the right:
Screens checked: consumer page, picker open, files selected,
onFilesPicked+onClose, cancel (onCancel+onClose). Below the header pill (which names the Node version), SSIM between base and head is 1.000 for the first three and above 0.998 for the last two, where only the log timestamps differ. Callback order is identical on both:onOpen, onFilesPicked, onClose, onOpen, onCancel, onClose, with no console errors.Checks
npm cinpm run buildnpm run lint(biome)tsc --noEmitnpm run test:coveragedist/outputtsc, esbuild bundlerequire()and ESMimportin Nodea07f07d(build, PR title, Aikido)Review gates on head a07f07d
/code-review(low): no findings.persist-credentials, npm token publishing instead of trusted publishing).pull_requestjob; the release job readspackage.jsonfrommain./security-review: pass; its service checklist items do not apply to a browser library..claude,.cursoror.agentsskills, no CLAUDE.md or AGENTS.md).volta.npmstays10.8.2(Node 22.23.5 ships npm 10.9.9, CI uses the bundled one), the release job usesnpm installinstead ofnpm ci, andnpm auditlists dev tooling advisories (vitest, vite, rollup) that are already onmain.Post-merge validation
mainrunsrelease-please.yml. This is aci:change, so release-please should not cut a release on its own. The next release PR it opens, once merged, builds on Node 22.23.5 and runsnpm publishwithNPM_TOKEN.Resolved package.json as 22.23.5; the build and publish steps pass;npm view @stackone/file-picker versionshows the new version; installing it in a consumer and opening the picker against staging (baseUrl: https://app.stackone-dev.com) firesonOpenandonFilesPickedas above.dist/should match this PR's build, which is byte identical tomain.Requested by guillaume@stackone.com in Slack (SEC-104 follow-up).
🤖 Generated with Claude Code