Skip to content

ci(workflow): bump Node to 22.23.5 for SEC-104 - #46

Open
glebedel wants to merge 6 commits into
mainfrom
s2d2/sec-104-ci-node-bump
Open

glebedel wants to merge 6 commits into
mainfrom
s2d2/sec-104-ci-node-bump

Conversation

@glebedel

@glebedel glebedel commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Moves file-picker off Node 20 (end of life) onto Node 22.23.5, the November 2026 Node security release, matching the rest of the org. package.json volta.node is now the single source of truth: both workflows read it with node-version-file: package.json, so CI, the release build and local Volta users all run the same version.

What changed

Where Before After
package.json volta.node 20.18.1 22.23.5
.github/workflows/node-ci.yml node-version: '20.18.x' node-version-file: package.json
.github/workflows/release-please.yml node-version: '20.18.x' node-version-file: package.json

No library code changes. There is no engines field, .nvmrc, Dockerfile or doc that pins Node, so nothing else says 20.x. The CI log on this head shows Resolved package.json as 22.23.5 and node: v22.23.5.

Evidence

Dogfood at the PR head: a scratch consumer app installs the npm pack tarball, is built on Node 22.23.5, opens the picker, selects two files and gets onFilesPicked, then opens it again and cancels. The picker iframe points at a local mock of app.stackone.com/embedded/files_picker that logs what the SDK sends (token masked) and what it posts back, because the real page needs a StackOne session token.

Dogfood on Node 22.23.5

Full recording (mp4) · mock log

Before (main, Node 20.18.1) on the left, after (this PR, Node 22.23.5) on the right:

Picker open, base vs head

onFilesPicked callback, base vs head

Screens checked: consumer page, picker open, files selected, onFilesPicked + onClose, cancel (onCancel + onClose). Below the header pill (which names the Node version), SSIM between base and head is 1.000 for the first three and above 0.998 for the last two, where only the log timestamps differ. Callback order is identical on both: onOpen, onFilesPicked, onClose, onOpen, onCancel, onClose, with no console errors.

Checks

Check main on Node 20.18.1 PR head on Node 22.23.5
npm ci pass pass
npm run build pass pass
npm run lint (biome) pass pass
tsc --noEmit pass pass
npm run test:coverage 6/6 6/6
dist/ output byte identical to main
Consumer: install tarball, strict tsc, esbuild bundle pass pass
Consumer: require() and ESM import in Node pass pass
CI on head a07f07d (build, PR title, Aikido) green
Review gates on head a07f07d
  • /code-review (low): no findings.
  • Security scan (security and dependency reviewers): no findings. Aikido has 0 open critical or high issues for this repo; 3 open low ones in these workflows predate this PR (checkout persist-credentials, npm token publishing instead of trusted publishing).
  • Codex security pass: nothing introduced. A PR can change the Node version only in the unprivileged pull_request job; the release job reads package.json from main.
  • /security-review: pass; its service checklist items do not apply to a browser library.
  • Repo skills: none in repo (no .claude, .cursor or .agents skills, no CLAUDE.md or AGENTS.md).
  • Not in scope, noted for a follow-up: volta.npm stays 10.8.2 (Node 22.23.5 ships npm 10.9.9, CI uses the bundled one), the release job uses npm install instead of npm ci, and npm audit lists dev tooling advisories (vitest, vite, rollup) that are already on main.

Post-merge validation

  • How it releases: merging to main runs release-please.yml. This is a ci: change, so release-please should not cut a release on its own. The next release PR it opens, once merged, builds on Node 22.23.5 and runs npm publish with NPM_TOKEN.
  • What to check after the next release: the release-please run log shows Resolved package.json as 22.23.5; the build and publish steps pass; npm view @stackone/file-picker version shows the new version; installing it in a consumer and opening the picker against staging (baseUrl: https://app.stackone-dev.com) fires onOpen and onFilesPicked as above.
  • Regression signals: a failed release-please or publish step, or consumer reports of import or type errors on the new version. The published dist/ should match this PR's build, which is byte identical to main.

Requested by guillaume@stackone.com in Slack (SEC-104 follow-up).

🤖 Generated with Claude Code

Refs SEC-104.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@glebedel
glebedel requested a review from a team as a code owner October 26, 2026 14:26
Copilot AI balanced review requested due to automatic review settings October 26, 2026 14:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread .github/workflows/node-ci.yml Resolved
@glebedel glebedel changed the title ci: bump Node to 22.x for CVE-2026-111497 ci(SEC-104): bump Node to 22.x for CVE-2026-111497 Oct 26, 2026
@glebedel glebedel changed the title ci(SEC-104): bump Node to 22.x for CVE-2026-111497 ci(workflow): bump Node to 22.x for CVE-2026-111497 (SEC-104) Oct 26, 2026
setup-node defaults check-latest to false, so a floating 22 can resolve to a
cached Node 22 older than 22.23.4. Addresses review feedback.

Refs SEC-104.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.

View guided diff | Turn on auto-fix | Re-trigger cubic

@glebedel glebedel changed the title ci(workflow): bump Node to 22.x for CVE-2026-111497 (SEC-104) ci(workflow): bump Node to 22.23.4 for CVE-2026-111497 (SEC-104) Oct 26, 2026
Workflows pinned Node separately from the repo's own version source, so
every Node bump had to be made twice. setup-node now reads
node-version-file: package.json, which makes package.json the only place to change.

- volta.node goes from 20.18.1 to 22.23.4 to match what CI already runs.
- .github/workflows/node-ci.yml: 1 step (was 22.23.4).
- .github/workflows/release-please.yml: 1 step (was 22.23.4).

Requested by guillaume@stackone.com in Slack.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@glebedel

Copy link
Copy Markdown
Contributor Author

Added a9a5a10: workflows now read node-version-file: package.json instead of a second hardcoded pin.

  • volta.node goes from 20.18.1 to 22.23.4 to match what CI already runs.
  • .github/workflows/node-ci.yml: 1 step (was 22.23.4).
  • .github/workflows/release-please.yml: 1 step (was 22.23.4).

Requested by guillaume@stackone.com in Slack.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 3 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Bump CI and Volta Node from 20.18.x to 22.23.4 to fix CVE-2026-111497; workflows now read the version from package.json. Only version pins and the version-file mechanism change, no workflow logic, and PR CI exercises the new version.

View guided diff | Turn on auto-fix | Re-trigger cubic

Keeps this branch from reintroducing a pre-fix Node when it merges.
https://nodejs.org/en/blog/vulnerability/november-2026-security-releases

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@glebedel glebedel changed the title ci(workflow): bump Node to 22.23.4 for CVE-2026-111497 (SEC-104) ci(workflow): bump Node to 22.23.5 for SEC-104 Nov 11, 2026

@glebedel glebedel left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review at head a07f07d8 (Node Nov 2026 security release, SEC-104).

  • Correctness (Codex pass over all 68 bump PRs): OK. Pins in this repo agree; no stale 22.23.4 / 24.22.1-2 / 26.12-13.0 left in the diff.
  • Security (Codex security-only pass): no findings. Lockfile node runtime URLs and hashes match the official SHASUMS256; no workflow permission or action-pin changes.
  • CI: all 4 checks green on this head.
  • Open review threads: 0.

Ready to merge from my side. GitHub approval still has to come from a person: s2d2 cannot approve PRs, and in this repo s2d2 acts with the same identity that opened the PR.

Requested by guillaume@stackone.com in Slack (#C05LDDNTJKV thread 1793813777.685889).

glebedel pushed a commit that referenced this pull request Nov 12, 2026
vite 8 / rolldown native bindings need Node 20.19+ or 22.12+; CI was pinned to 20.18.x.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants