feat(notice): support custom icons - #2419
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b97478b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stackoverflow-email ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dancormier
marked this pull request as ready for review
September 28, 2026 17:23
asblanco
previously approved these changes
Oct 1, 2026
asblanco
left a comment
asblanco
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I just added the possibility to set icon on the Custom icon storybook case
asblanco
enabled auto-merge (squash)
October 1, 2026 09:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.atlassian.net/browse/STACKS-931
Summary
Allow neutral notices to use an information icon without recreating the component’s markup or dismissal behavior. An optional
iconprop overrides the icon independently ofvariant, while existing callers retain their default icons, titles, and styling.Changes
iconprop, consistent with other Stacks Svelte components.iconTitlewhen supplied and are decorative otherwise, without inheriting the variant’s title.@stackoverflow/stacks-svelte. No Toast API, Classic CSS, or dependency changes.How to test
npm run storybook -w packages/stacks-svelte. Dependencies must be installed.npm run lint -w packages/stacks-svelte,npm run build -w packages/stacks-svelte, andnpm run test -w packages/stacks-svelte.Latest verification: all 11 Notice tests, including an automated accessibility check, pass. Lint/type checks, formatting, and diff checks pass. Before the test-only reduction, the full Svelte suite passed with 602 browser tests and 29 tooling tests; package and Storybook builds also passed. The full suite was not rerun after reducing the tests.
Local visual review completed. Manual screen-reader verification remains outstanding.
Netlify Storybook preview — Custom icon
Success criteria
Screenshots