Repository navigation
fix(auth): resolve environment token when constructing clients (proof of concept) - #34
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept for #33; this generated-code change needs to be ported into the API definition/generator before it can survive regeneration. It is not merge-ready as-is. No generated source is added to
.fernignoreand no release/version/publish configuration is changed.SpeechifyandAsyncSpeechifycaptureSPEECHIFY_API_KEYwhile importing the module becauseos.getenvis a parameter default. Loading dotenv or retrieving a secret after importing therefore fails to authenticate a new client. Updating or removing the variable after import also leaves new clients using the old key.Default
tokentoNoneand resolve the environment inside each constructor when no explicit token is supplied. Explicit string and callable tokens keep precedence.Twelve offline public-client cases cover both clients with late, replaced, removed and absent environment keys plus explicit-string/callable controls. Six fail on the original source. All 78 tests pass afterward, with four optional/unimplemented tests skipped.
httpx.MockTransportverifies the Authorization header on actual models requests; no live service or real key is used. Full Ruff lint/format (106 files), mypy (106 source files, one informational untyped-body note), wheel/sdist build and diff checks pass. Developed with AI assistance and verified locally.