Skip to content

use the new manage access dialog #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SharonStrats wants to merge 4 commits into
base: staging
Choose a base branch
from
Open

use the new manage access dialog #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0af5ccb
use the new manage access dialog
SharonStrats Sep 26, 2026
e01fd4b
Merge branch 'staging' into feat/access
SharonStrats Oct 15, 2026
4a045ac
chore: update solidos dependencies (dev: solid-logic@6.0.1-1 pane-reg…
github-actions[bot] Oct 15, 2026
bab148a
chore: update solidos dependencies (dev: solid-logic@6.0.1-1 pane-reg…
github-actions[bot] Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
154 changes: 77 additions & 77 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 12 additions & 3 deletions src/outline/manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import * as paneRegistry from 'pane-registry'
import './manager.css'
import * as $rdf from 'rdflib'
import * as UI from 'solid-ui'
import { store } from 'solid-logic'
import { solidLogicSingleton, store } from 'solid-logic'
import { propertyViews } from './propertyViews'
import { outlineIcons } from './outlineIcons.js' // @@ chec
import { UserInput } from './userInput.js'
Expand All @@ -20,6 +20,7 @@ import { announceNavigation } from '../navigation/events'
import { resolveSource } from '../navigation/options'
import { refreshNavbarVisibility } from '../navigation/navbarVisibility'
import '../components/file-explorer-header'
import AccessControlModal from 'solid-ui/components/access-control-modal'

export default function (context) {
const dom = context.dom
Expand Down Expand Up @@ -481,8 +482,16 @@ export default function (context) {
provider.paneRenderOptions = options
provider.soloPane = options.solo
provider.openPane = (paneSubject, paneName) => openPaneInPlace(paneSubject, paneRegistry.byName(paneName))
// TODO: for now we do this until we create sharing dialog in solid-panes
provider.handleAccessClick = () => openPaneInPlace(subject, paneRegistry.byName('sharing'))
provider.handleAccessClick = async () => {
const accessGrants = await solidLogicSingleton.acl.findAccessGrants(subject)

UI.showDialog(AccessControlModal, {
props: {
subjectUri: subject.uri,
accessGrants
}
})
}

if (provider.pane) {
tr.classList.add('outlinePaneRow')
Expand Down
Loading