Repository navigation
Stabilize the native MySQL clone interruption test - #311
Open
colinmollenhour wants to merge 1 commit into
Open
colinmollenhour wants to merge 1 commit into
colinmollenhour wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Give the native MySQL launcher test enough time to interrupt a real clone after both rollback markers appear. The test still checks that a restart rolls the clone back and preserves the recipient’s
server_uuid.Why
The v1.8.0 release gate failed when the throttled clone completed before the test could kill it. In a local replay on the release image, the old fixture finished in 48.6 seconds, within the test’s one-minute polling window. Release run
Closes #309.
Changes
Test Plan
BLOODRAVEN_MYSQL_NATIVE_TEST=1 BLOODRAVEN_MYSQL_NATIVE_IMAGE=mysql@sha256:df90258da46f6e7ff8574ff84f17618aba0765cac749928299c69fd4e7cb8ad8 go test ./internal/controller -run '^TestMySQLLauncherNative$' -v -count=1 -timeout=10mpassed all four variants on the release image.make generate && make manifestsproduced no diff.make vet,make lint, andmake testpassed in a clean checkout.