Skip to content

Stabilize the native MySQL clone interruption test - #311

Open
colinmollenhour wants to merge 1 commit into
mainfrom
309_STABILIZE-NATIVE-CLONE-TEST
Open

colinmollenhour wants to merge 1 commit into
mainfrom
309_STABILIZE-NATIVE-CLONE-TEST

Conversation

@colinmollenhour

Copy link
Copy Markdown
Collaborator

AI · By: Codex with GPT-6.2 Sol

Summary

Give the native MySQL launcher test enough time to interrupt a real clone after both rollback markers appear. The test still checks that a restart rolls the clone back and preserves the recipient’s server_uuid.

Why

The v1.8.0 release gate failed when the throttled clone completed before the test could kill it. In a local replay on the release image, the old fixture finished in 48.6 seconds, within the test’s one-minute polling window. Release run

Closes #309.

Changes

  • Seed the donor with 256 MiB of test data and run the interrupted clone with one copy thread targeting 1 MiB/s. Keep the fixture out of the binary log and drop it before the successful retry.
  • Bound marker polling and the container kill to one minute. Log the clone’s elapsed time and the number of marker polls.

Test Plan

  • BLOODRAVEN_MYSQL_NATIVE_TEST=1 BLOODRAVEN_MYSQL_NATIVE_IMAGE=mysql@sha256:df90258da46f6e7ff8574ff84f17618aba0765cac749928299c69fd4e7cb8ad8 go test ./internal/controller -run '^TestMySQLLauncherNative$' -v -count=1 -timeout=10m passed all four variants on the release image.
  • A temporary diagnostic delayed the encrypted variant’s first marker poll by 60 seconds. It still found both markers, killed the recipient, and passed the rollback assertions.
  • make generate && make manifests produced no diff. make vet, make lint, and make test passed in a clean checkout.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestMySQLLauncherNative/encryption_at_rest: the throttled clone can end before the test kills it (flaked in the v1.8.0 release gate)

1 participant