Skip to content

fix(zeronym): correct the non-finalized nullifier comment - #111

Open
hu55a1n1 wants to merge 3 commits into
hub-flush-unknown-anchorfrom
hub-flush-non-finalized-nullifier
Open

hu55a1n1 wants to merge 3 commits into
hub-flush-unknown-anchorfrom
hub-flush-non-finalized-nullifier

Conversation

@hu55a1n1

@hu55a1n1 hu55a1n1 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Stacked on #110. GitHub retargets this to main when #110 merges.

What

The comment on in finalized state: false called that string a mempool conflict. It is the non-finalized best chain. The arm is unchanged: that string is AlreadyKnown. A mempool-versus-mempool conflict does not contain duplicate. A missing prevout stays Retryable.

Tests

zebras_double_spend_is_a_rejection_except_on_the_non_finalized_chain pins AlreadyKnown for the false string and Retryable for the missing prevout. The true string stays Rejected.

cargo test --manifest-path zeronym/hub/Cargo.toml --lib -- zebras_double_spend passed. This commit is a comment plus a #[cfg(test)] change, so the release binary matches #110.

Pending

Made with Cursor

`in finalized state: false` is the non-finalized best chain, so that reply stays AlreadyKnown. A missing prevout stays retryable.

Co-authored-by: Cursor <cursoragent@cursor.com>
@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
this host disagrees with the PUBLISHED hash./
this host disagrees with the PUBLISHED hash.
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant