Repository navigation
Conversation
`in finalized state: false` is the non-finalized best chain, so that reply stays AlreadyKnown. A missing prevout stays retryable. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Found 1 test failure on Blacksmith runners: Failure
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Stacked on #110. GitHub retargets this to
mainwhen #110 merges.What
The comment on
in finalized state: falsecalled that string a mempool conflict. It is the non-finalized best chain. The arm is unchanged: that string isAlreadyKnown. A mempool-versus-mempool conflict does not containduplicate. A missing prevout staysRetryable.Tests
zebras_double_spend_is_a_rejection_except_on_the_non_finalized_chainpinsAlreadyKnownfor thefalsestring andRetryablefor the missing prevout. Thetruestring staysRejected.cargo test --manifest-path zeronym/hub/Cargo.toml --lib -- zebras_double_spendpassed. This commit is a comment plus a#[cfg(test)]change, so the release binary matches #110.Pending
EXPECTED_SHA256commit. Runreproduce.shonce fix(zeronym): requeue an unknown anchor once, then burn it #110's hash is in, and do not expect a new hash from this diff.Made with Cursor