Repository navigation
Shade a themed layout borders and all; Shaded.Target for borders or text only (2.22.0) - #69
Merged
Merged
Conversation
A theme's part colours (border, title, labels, headings, bullets, guides) were laid inside a Shaded block's gradient and won over it, so a box drawn in a game's theme showed the gradient only in its plain text. Inside a Shaded block those part colours are now left off; colour the text sets itself and a table's stripe are kept. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TzLbKjac4jFHdFDJtUMwsu
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 12
✨ Finishing Touches
Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TzLbKjac4jFHdFDJtUMwsu
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TzLbKjac4jFHdFDJtUMwsu
…umns Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TzLbKjac4jFHdFDJtUMwsu
HarryCordewener
marked this pull request as ready for review
October 21, 2026 03:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Grave · project thread
Release as 2.22.0 (adds public API). SharpMUSH/SharpMUSH#2129 depends on it.
Fixed
Shadedblock laid its gradient outside the content's lines and aLayoutTheme's part colours (border, title, labels, headings, bullets, guides) inside, so they won. A box under a game's theme showed the gradient only in its plain text. That is whygradient(box(Sheet,Mannaz,20),hc|hm,{"flow":"diagonal"})showed no gradient in SharpMUSH telnet. Inside a shaded block the theme's colours for the shaded parts are now left off. Colour the text sets itself is kept, and so is a stripe (a background).across/diagonalreached only the first few colours. The colours now run over what is drawn. In HTML a shaded block that holds nothing full-width (no box, rule, flex row or gauge) iswidth: fit-content, for the same reason.Added
Shaded.Target(GradientTarget.All/Borders/Text): shade only the box drawing (borders and rules, table column separators and heading rules, tree guides, gauge brackets) or only the text. The other part keeps its own or its theme's colour. Box drawing is told apart by an internal data-markup mark (LinePiece) laid on while drawing and taken off after shading. The codec writestg. HTML addsms-shade-borders/ms-shade-text, and the stylesheet clips only that part.Before / after, xterm-256, a box in a theme with a blue border and yellow title, shaded
hc|hmdiagonally:Tests
New
CompositionTests: a theme colours none of a shaded box's parts; colour the text sets is kept;acrossruns over what is drawn (fails before the fix);Borderskeeps the title's theme colour and writes no background-image in HTML;Textkeeps a table's separator and heading-rule theme colours and leaves no data markup behind;Targetsurvives the wire. Full suite: 1366 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01TzLbKjac4jFHdFDJtUMwsu
Summary by CodeRabbit
New Features
Bug Fixes