Repository navigation
fix(security): use cryptographic randomness for selection - #67
Merged
Merged
Conversation
|
🎉 This PR is included in version 2.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace predictable random selection with Web Crypto and rejection sampling.
Validate selection bounds and handle arrays emptied after initialization.
Require Node.js 20 or later and document the secure randomness behavior.
Migrate package tooling to pnpm 12 and Vite, and update pinned CI actions.
Add focused regression and package export/type tests.
Add local Vite playgrounds, updated README examples, and repository-specific AGENTS.md and Copilot instructions.
Validation
All five playground production builds pass; playground typechecks are included in the package typecheck.
Local pnpm test, typecheck, lint, and format:check pass.
pnpm audit and git diff --check pass.
ESM/CJS runtime exports and NodeNext consumer types pass.
Latest GitHub PR checks pass, including tests, type checks, lint/format, security audit, and artifact upload.
This PR does not publish an npm release.