Skip to content

fix: pilot findings on real Runroom repositories; release 1.3.0 - #18

Merged
Cenadros merged 2 commits into
mainfrom
fix/pilot-findings
Sep 23, 2026
Merged

Cenadros merged 2 commits into
mainfrom
fix/pilot-findings

Conversation

@Cenadros

Copy link
Copy Markdown
Contributor

Summary

A pilot of the gate on aulaclinic_web (Next + Payload), Colonial (Drupal 11) and santalucia-reports (Python 3.14 + Vite frontend) surfaced these issues. After the fixes, init and check pass on all three.

Repo Before After
aulaclinic_web 138 complexity, 17 unused 67 complexity (JSX thresholds), 15 unused
Colonial composer install aborted (no patch) init and check PASS, TS unused included
santalucia-reports deptry 3833 findings then crash; frontend undetected deptry 9 plausible findings; frontend detected; Knip runs
  • Image ships patch for composer-patches.
  • deptry: first-party packages from the Python paths, repeated diagnostics counted, test exclusions with picomatch-compatible regexes, distribution→module map from the consumer .venv keyed by the declared spelling, untrusted names validated.
  • TS detected from depth-1 directories with their own package.json (not cypress/, e2e/, fixtures/…).
  • Knip runs from the sole owning package when the root has no package.json; adds global-not-found and next-intl entries.
  • Python module-level diagnostics no longer print anchor fallback notices.
  • JSX thresholds: complexity 15, 120 lines per function.
  • docs/ci.md: setup may chain installers (composer install --no-interaction && npm ci).

Release

Version 1.3.0 (root, launcher, CLI_VERSION). POLICY_VERSION is 2026-09-23.2; after upgrading, remove quality/ and run code-quality check --initialize.

Verification

  • typecheck, lint, 722 tests.
  • pnpm docker:build && pnpm integration: all rows green; all fixture and repository baselines regenerated.
  • Closing correctness and security review: 3 Important and 10 Minor findings fixed.

- Image ships `patch` so composer-patches can apply Drupal patches.
- deptry passes first-party packages from the Python paths, counts repeated
  diagnostics, excludes tests with picomatch-compatible regexes, and maps
  distributions to modules from the consumer .venv using the declared
  dependency spelling; untrusted names are validated before reaching the map.
- TS is detected from depth-1 directories with their own package.json.
- Knip runs from the sole owning package when the root has no package.json
  and adds the global-not-found and next-intl request entries.
- Python module-level diagnostics no longer print anchor fallback notices.
- JSX files get their own thresholds: complexity 15, 120 lines per function.
- POLICY_VERSION 2026-09-23.2; baselines regenerated.
- Release 1.3.0.
@Cenadros
Cenadros requested a review from a team September 23, 2026 08:49
@Cenadros
Cenadros merged commit 91c4021 into main Sep 23, 2026
8 checks passed
@Cenadros
Cenadros deleted the fix/pilot-findings branch September 23, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant