Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MultiDict.getitem returns the last value for a repeated key, but setdefault() returns its first value. A caller checking or using the value returned by setdefault therefore receives a different value from the mapping's current value.
Search existing entries in reverse order, consistently with getitem. Extend the shared setdefault regression to check the return value, preserve all repeated values, and retain the missing-key default behavior. This covers both MultiDict and the query-string-backed GetDict.
Validation on Python 3.12.14: the two mutable-mapping regressions fail before the fix and two controls pass. After the fix, the full suite has 2395 passed, 3 skipped, 1 xfailed and 14 warnings. Black and git diff --check pass.