Repository navigation
Conversation
A Range header with neither a first nor a last byte position matched the
regex with two empty groups, and int('') raised ValueError. That made
req.range, and any conditional_response app serving the request, raise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request with the header
Range: bytes=-makes WebOb raise instead of ignoring the malformed header:Because the header comes from the client, any app that uses
conditional_response=True(for example static file serving) returns a 500 for that request.Cause:
_rx_rangeisbytes *= *(\d*) *- *(\d*), sobytes=-matches with both groups empty.Range.parsethen takes the suffix branch and callsint(""). Other malformed values already returnNone(the documented "may return None if header is invalid").Fix: return
Nonewhen both positions are empty. The header is then ignored, as for other invalid ranges.Tests:
test_range_parse.Both fail without the change. The full suite passes (2399 passed), and black and isort are clean. I also added a Bugfix entry to
CHANGES.txt.This doesn't overlap with #502, which changes
range_for_lengthfor oversized suffix ranges.AI-assisted (Claude): I used it to help read the code and draft the test. I reviewed and ran everything myself.