Repository navigation
Conversation
bobbyxng
requested review from
brynpickering and
ekatef
and
a lite review from Copilot
October 6, 2026 15:26
Collaborator
Author
|
I used module_powerplants as a reference for the module structure and environment setup, adapting these conventions to grid-builder’s workflow. Any tips and comments from our Modelblocks experts is very welcome @jnnr @brynpickering @irm-codebase |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
INTERFACE.yaml must document the retrieval pathvars and country wildcard exposed by the workflow.
Review effort: Lite
Findings: 1
What changed in this PR
Fixes remote Snakemake imports and aligns workflow paths, environments, configuration, and documentation with Modelblocks conventions.
Changes:
- Resolves remote scripts, schemas, helpers, and regional configurations.
- Rewires workflow outputs through configurable pathvars.
- Consolidates locked environments and adds regression coverage.
- Updates interface metadata and documentation.
| File | Summary |
|---|---|
workflow/Snakefile |
Remote source loading and pathvars |
workflow/scripts/retrieve_osm_pbf.py |
Retrieval imports and configuration |
workflow/scripts/retrieve_osm_overpass.py |
Overpass retrieval updates |
workflow/scripts/clean.py |
Cleaning workflow updates |
workflow/scripts/build_network.py |
Network build imports and paths |
workflow/scripts/build_interactive_map.py |
Interactive map updates |
workflow/scripts/_schema.py |
Schema handling |
workflow/scripts/_helpers.py |
Shared helper imports |
workflow/rules/retrieve.smk |
Retrieval rule rewiring |
workflow/rules/plot.smk |
Plot rule paths |
workflow/rules/network.smk |
Network rule paths and environment |
workflow/internal/config.schema.yaml |
Configuration schema |
workflow/envs/retrieve.yaml |
Retrieval environment |
workflow/envs/network.yaml |
Network environment |
workflow/envs/module.yaml |
Consolidated module environment |
workflow/envs/module.win-64.pin.txt |
Windows package pins |
workflow/envs/module.osx-arm64.pin.txt |
macOS package pins |
workflow/envs/module.linux-64.pin.txt |
Linux package pins |
tests/test_module_import.py |
Remote import and rewiring tests |
tests/test_environments.py |
Environment validation |
tests/test_config.py |
Configuration tests |
tests/integration/Snakefile |
Integration pathvars |
tests/integration_test.py |
Updated integration paths |
scripts/export_snakemake_env.py |
Environment export utility |
README.md |
Usage and development documentation |
pytest.ini |
Python path configuration |
pixi.toml |
Module environment definitions |
pixi.lock |
Locked dependencies |
mypy.ini |
Module search path |
INTERFACE.yaml |
Interface metadata; retrieval pathvars and wildcard are missing |
config/regions/index.yaml |
Regional source manifest |
config/README.md |
Configuration documentation |
config/config.yaml |
Schema reference |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| map: | ||
| default: <results>/map.html | ||
| description: Network map. | ||
| wildcards: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes Issue #9 @jnnr
Summary of changes in this pull request
github()helper, resolving the reportedImportError: cannot import name 'load_region_configs' from 'scripts._schema'. Load module sources and regional configuration independently of the consuming workflow.<resources>/automatic, final outputs under<results>, and configurable output pathvars.Reviewer checklist
pipdependencies in the module's environment files (workflow/envs/).pathvars(e.g.,<results>) in their inputs and outputs.pre-commit.citests pass.INTERFACE.yamlmentions all relevantpathvarsandwildcards.README.mddescribes how to use the module and has the necessary citations.