Repository navigation
test(cpu): pin high-register PC reads; changelog for the ADD fix - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR rescues three local commits from 2026-09-21 that were never pushed.
masteralready has the high-registerADDPC-read fix (465fd7c, and it is more complete than the local version), but two things were missing:ADD,MOVandCMPforms to the instruction address + 4. One test places the instruction at a halfword-aligned address.MOVandCMPalready behave correctly, but until now no test guarded them. The conflict with theADDtest thatmasteralready had was resolved by keeping all three tests.masterhad no entry for the fix. The entry now describes all threeADDforms and the MicroPython native-module symptom.No code changes.
Verification
Unit suite: 583 passed, 0 failed.