Skip to content

Fix type code of radiation inputs - #58

Merged
nielstron merged 1 commit into
masterfrom
fix/radiation-type
Nov 16, 2026
Merged

nielstron merged 1 commit into
masterfrom
fix/radiation-type

Conversation

@nielstron

Copy link
Copy Markdown
Member

TA's interface spec (archived copy, input bit layout) encodes radiation as V110 TTTT TTTT TTTT, i.e. type bits 0x6000. pyblnet used 0x4000 (an undocumented type).

The value was decoded correctly anyway (radiation falls through to the default conversion), but direct-mode inputs got type: None and no unit_of_measurement instead of radiation / W/m². pyblnet-async also uses 0x6000.

The updated parser test fails on master.

TA's interface spec encodes radiation inputs as V110 TTTT TTTT TTTT,
type bits 0x6000, not 0x4000. The value was decoded correctly anyway
since radiation falls through to the default conversion, but the input
type was reported as None instead of radiation, so fetch() gave it no
unit. pyblnet-async uses 0x6000 as well.
@nielstron
nielstron merged commit 883c62e into master Nov 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant