Repository navigation
Fix type code of radiation inputs - #58
Merged
Merged
Conversation
TA's interface spec encodes radiation inputs as V110 TTTT TTTT TTTT, type bits 0x6000, not 0x4000. The value was decoded correctly anyway since radiation falls through to the default conversion, but the input type was reported as None instead of radiation, so fetch() gave it no unit. pyblnet-async uses 0x6000 as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TA's interface spec (archived copy, input bit layout) encodes radiation as
V110 TTTT TTTT TTTT, i.e. type bits0x6000. pyblnet used0x4000(an undocumented type).The value was decoded correctly anyway (radiation falls through to the default conversion), but direct-mode inputs got
type: Noneand nounit_of_measurementinstead ofradiation/W/m². pyblnet-async also uses0x6000.The updated parser test fails on master.