Skip to content

Replace htmldom with html.parser - #53

Merged
nielstron merged 1 commit into
masterfrom
fix/replace-htmldom
Nov 16, 2026
Merged

nielstron merged 1 commit into
masterfrom
fix/replace-htmldom

Conversation

@nielstron

Copy link
Copy Markdown
Member

Cherry-picked from #48 (by Alexander Eisele), without the fork-specific changes (uv migration, Python 3.11 requirement, pyupgrade, PyPI/README fork changes, CLAUDE.md, version bumps).

htmldom is unmaintained and mangles parts of the BL-NET pages (button text "<=" ends up as tag fragments). A small html.parser-based helper extracts element text the way the value regexes expect. requests becomes the only runtime dependency.

Adds tests on the saved device pages (negative values, access denied page, blnet_test). These pass with both the old and new implementation, so this is a dependency cleanup, not a behavior change covered by tests. Tests pass without htmldom installed.

htmldom is unmaintained and mangles parts of the BL-NET pages (button
text "<=" ends up as tag fragments in the extracted text). A small
html.parser based helper extracts the text of matching elements the
way the value regexes expect: entities like &nbsp; kept as written and
<br> as newline, including nested matching elements.

Adds tests on the saved device pages for cases the mock server tests
didn't cover (negative values, access denied page, blnet_test). They
pass with both implementations, and both give identical results on all
saved pages. requests is now the only runtime dependency.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nielstron
nielstron merged commit b199b4f into master Nov 16, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants