Repository navigation
Replace htmldom with html.parser - #53
Merged
Merged
Conversation
htmldom is unmaintained and mangles parts of the BL-NET pages (button text "<=" ends up as tag fragments in the extracted text). A small html.parser based helper extracts the text of matching elements the way the value regexes expect: entities like kept as written and <br> as newline, including nested matching elements. Adds tests on the saved device pages for cases the mock server tests didn't cover (negative values, access denied page, blnet_test). They pass with both implementations, and both give identical results on all saved pages. requests is now the only runtime dependency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nielstron
force-pushed
the
fix/replace-htmldom
branch
from
November 16, 2026 14:27
66d94fd to
d6faba0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #48 (by Alexander Eisele), without the fork-specific changes (uv migration, Python 3.11 requirement, pyupgrade, PyPI/README fork changes, CLAUDE.md, version bumps).
htmldom is unmaintained and mangles parts of the BL-NET pages (button text "<=" ends up as tag fragments). A small
html.parser-based helper extracts element text the way the value regexes expect.requestsbecomes the only runtime dependency.Adds tests on the saved device pages (negative values, access denied page,
blnet_test). These pass with both the old and new implementation, so this is a dependency cleanup, not a behavior change covered by tests. Tests pass without htmldom installed.